<div dir="auto"><div><br><div class="gmail_extra"><br><div class="gmail_quote">On Nov 23, 2017 17:23, "Nir Soffer" <<a href="mailto:nsoffer@redhat.com">nsoffer@redhat.com</a>> wrote:<br type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><br><div class="gmail_quote"><div class="quoted-text"><div dir="ltr">On Thu, Nov 23, 2017 at 4:55 PM Dan Kenigsberg <<a href="mailto:danken@redhat.com" target="_blank">danken@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Thu, Nov 23, 2017 at 4:03 PM, Nir Soffer <<a href="mailto:nsoffer@redhat.com" target="_blank">nsoffer@redhat.com</a>> wrote:<br>
> On Thu, Nov 23, 2017 at 3:59 PM Dan Kenigsberg <<a href="mailto:danken@redhat.com" target="_blank">danken@redhat.com</a>> wrote:<br>
>><br>
>> On Thu, Nov 23, 2017 at 1:56 PM, Nir Soffer <<a href="mailto:nsoffer@redhat.com" target="_blank">nsoffer@redhat.com</a>> wrote:<br>
>> > On Thu, Nov 23, 2017 at 1:51 PM Edward Haas <<a href="mailto:ehaas@redhat.com" target="_blank">ehaas@redhat.com</a>> wrote:<br>
>> >><br>
>> >> Per what I see, all CI jobs on vdsm/fc27 fail.<br>
>> >> This is the second time this week, please consider reverting.<br>
>> >><br>
>> >> We should try to avoid such changed before the weekend<br>
>> ><br>
>> ><br>
>> > Some of the failures like<br>
>> ><br>
>> > <a href="http://jenkins.ovirt.org/job/vdsm_master_check-patch-fc27-x86_64/100/console" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/job/<wbr>vdsm_master_check-patch-fc27-<wbr>x86_64/100/console</a><br>
>> ><br>
>> > Should be fixed by:<br>
>> > <a href="https://gerrit.ovirt.org/84569/" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/<wbr>84569/</a><br>
>> ><br>
>> > I have see some network test failing when running mock_runner locally,<br>
>> > you may need to mark them as broken on fc27.<br>
>><br>
>> We have a busy couple of weeks until release of ovirt-4.2.0. As much<br>
>> as I like consuming Fedora early, I'm not sure that enabling so close<br>
>> to the release was a good idea. Nothing forces us to do it now (and<br>
>> there are a lot of reasons to do it later). Let's give it another go,<br>
>> but let us not keep it on the red for the weekend.<br>
><br>
><br>
> I'm happy with the storage code being tested on current fedora.<br>
<br>
I'm more than happy. I'm thrilled to for it to be tested and run.<br>
I am not happy to give a vote to a job that was never ever successful.<br></blockquote><div><br></div></div><div>The job is successful,</div></div></div></blockquote></div></div></div><div dir="auto"><br></div><div dir="auto">That's an oversimplification. <a href="http://jenkins.ovirt.org/job/vdsm_master_check-patch-fc27-x86_64/174/consoleText">http://jenkins.ovirt.org/job/vdsm_master_check-patch-fc27-x86_64/174/consoleText</a> fails with another dependency</div><div dir="auto"><br></div><div dir="auto"><pre style="word-wrap:break-word;white-space:pre-wrap"> - nothing provides mom >= 0.5.8 needed by vdsm-4.20.8-1.git383bc1031.fc27.x86_64
- nothing provides mom >= 0.5.8 needed by vdsm-4.20.8-3.gita9ee9c65f.fc27.x86_64
- nothing provides python-argparse needed by vdsm-4.18.999-444.git0bb7717.fc27.x86_64</pre></div><div dir="auto"><br></div><div dir="auto"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div> some tests or maybe the code they test need work.</div><div>This is why we have skipif/xfail and broken_on_ci.</div><div class="quoted-text"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
><br>
> Please make sure the few failing network tests are not breaking the build.<br>
<br>
It's probably time to mark the tests that use loseup as broken-on-jenkins<br></blockquote><div><br></div></div><div>loop devices are usually ok on jenkins. We have several tests in storage using</div><div>them and I don't know about any failures. For example storage/blockdev_test.py.</div><div><br></div><div>Francesco, do you want to mark them as broken for now?</div><div class="elided-text"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
ERROR: Tests mkimage.injectFilesToFs creating an image and checking its<br>
------------------------------<wbr>------------------------------<wbr>----------<br>
Traceback (most recent call last):<br>
File "/home/jenkins/workspace/vdsm_<wbr>master_check-patch-el7-x86_64/<wbr>vdsm/tests/testlib.py",<br>
line 143, in wrapper<br>
return f(self, *args)<br>
File "/home/jenkins/workspace/vdsm_<wbr>master_check-patch-el7-x86_64/<wbr>vdsm/tests/testValidation.py",<br>
line 191, in wrapper<br>
return f(*args, **kwargs)<br>
File "/home/jenkins/workspace/vdsm_<wbr>master_check-patch-el7-x86_64/<wbr>vdsm/tests/mkimage_test.py",<br>
line 176, in test_injectFilesToFs<br>
mkimage.injectFilesToFs(<wbr>floppy, self.files, fstype)<br>
File "/home/jenkins/workspace/vdsm_<wbr>master_check-patch-el7-x86_64/<wbr>vdsm/lib/vdsm/mkimage.py",<br>
line 112, in injectFilesToFs<br>
m.mount(mntOpts='loop', vfstype=fstype)<br>
File "/home/jenkins/workspace/vdsm_<wbr>master_check-patch-el7-x86_64/<wbr>vdsm/lib/vdsm/storage/mount.<wbr>py",<br>
line 208, in mount<br>
cgroup=cgroup)<br>
File "/home/jenkins/workspace/vdsm_<wbr>master_check-patch-el7-x86_64/<wbr>vdsm/lib/vdsm/storage/mount.<wbr>py",<br>
line 278, in _mount<br>
_runcmd(cmd)<br>
File "/home/jenkins/workspace/vdsm_<wbr>master_check-patch-el7-x86_64/<wbr>vdsm/lib/vdsm/storage/mount.<wbr>py",<br>
line 306, in _runcmd<br>
raise MountError(rc, ";".join((out, err)))<br>
MountError: (32, ';mount:<br>
/tmp/vdsm-mkimage-testspahtvm/<wbr>images/vmId_inject.<wbr>7301b08f8c0dc496bedd25577dbddb<wbr>d8.img:<br>
failed to setup loop device: No such file or directory\n')<br>
<br>
<br>
<br>
><br>
> Nir<br>
><br>
><br>
</blockquote></div></div></div>
</blockquote></div><br></div></div></div>