<div dir="ltr">Thanks to you too for checking.<div><br><div>Martin</div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Nov 29, 2017 at 3:07 PM, Greg Sheremeta <span dir="ltr"><<a href="mailto:gshereme@redhat.com" target="_blank">gshereme@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Discussed with Alexander, and yep this is an issue.<div>I opened <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1518724" target="_blank">https://bugzilla.redhat.com/<wbr>show_bug.cgi?id=1518724</a><br></div><div><br></div><div>Thanks for checking and reporting!</div><div><div class="h5"><div> <div class="gmail_extra"><div class="gmail_quote">On Wed, Nov 29, 2017 at 8:35 AM, Greg Sheremeta <span dir="ltr"><<a href="mailto:gshereme@redhat.com" target="_blank">gshereme@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">+Alexander, can you take a look?<div class="gmail_extra"><div><div class="m_-7903319557425054007gmail-m_-2217787408152018609h5"><br><div class="gmail_quote">On Wed, Nov 29, 2017 at 8:33 AM, Martin Sivak <span dir="ltr"><<a href="mailto:msivak@redhat.com" target="_blank">msivak@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi,<div><br></div><div>I think I found one issue.. I do not see the extra menu items that were supposed to be added to VMs (used to be available in context menu as well).</div><div><br></div><div>You can check it with</div><div><br></div><div><a href="http://jenkins.ovirt.org/job/ovirt-optimizer_master_check-patch-el7-x86_64/65/" target="_blank">http://jenkins.ovirt.org/job/o<wbr>virt-optimizer_master_check-pa<wbr>tch-el7-x86_64/65/</a><span class="m_-7903319557425054007gmail-m_-2217787408152018609m_-3331247846607507906HOEnZb"><font color="#888888"><br></font></span></div><span class="m_-7903319557425054007gmail-m_-2217787408152018609m_-3331247846607507906HOEnZb"><font color="#888888"><div><br></div><div>Martin</div></font></span></div><div class="m_-7903319557425054007gmail-m_-2217787408152018609m_-3331247846607507906HOEnZb"><div class="m_-7903319557425054007gmail-m_-2217787408152018609m_-3331247846607507906h5"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Nov 29, 2017 at 1:22 AM, Greg Sheremeta <span dir="ltr"><<a href="mailto:gshereme@redhat.com" target="_blank">gshereme@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hey,<div><br></div><div>We haven't changed the API, so everything should still work. For example, I just installed 4.1 versions of dashboard and support-plugin in master, and all's well [*]:<div><br></div><div>API:</div><div><br></div><div><div>api.addSubTab('Template', 'Red Hat Documentation', 'my-host-subtab-template', '<url snip>', {alignRight: true});</div><div>api.setTabAccessible('my-host-<wbr>subtab-template', true);</div><div><br></div><div><img src="cid:ii_160051f196581285" alt="Inline image 1" width="539" height="66"><br></div><div><br></div><div>[*] however, note that "alignRight" is now ignored<br></div><div><br></div><div>And dashboard 4.1.8 installed in master engine:</div><div><br></div><div><img src="cid:ii_160052092345cad7" alt="Inline image 2" width="539" height="290"><br></div><div><br></div><div><div><br></div><div>That said, we probably should have sent some announcement about making sure the plugins actually look good with the new theme. If some plugins are greenish, that will look bad.</div><div><br></div><div>To help with styling external things, we've started exposing more CSS via a new SASS brand module:</div><div><a href="https://github.com/oVirt/ovirt-engine/tree/master/frontend/brands/ovirt-brand/src/main/sass" target="_blank">https://github.com/oVirt/ovirt<wbr>-engine/tree/master/frontend/b<wbr>rands/ovirt-brand/src/main/sas<wbr>s</a></div><div>Also, we're heavily relying on base PatternFly styles, and plugins should do the same. For example, the new dialog styles are completely PatternFly [<a href="http://www.patternfly.org/pattern-library/forms-and-controls/modal-overlay/" target="_blank">http://www.patternfly.org/pat<wbr>tern-library/forms-and-control<wbr>s/modal-overlay/</a>] and we don't do anything extra on top of that.<br><div><br></div><div>Let us know if something doesn't work, or you need help styling something.</div><div><br></div><div>Greg</div><div><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="m_-7903319557425054007gmail-m_-2217787408152018609m_-3331247846607507906m_5190463728797355581h5">On Tue, Nov 28, 2017 at 6:25 PM, Martin Sivak <span dir="ltr"><<a href="mailto:msivak@redhat.com" target="_blank">msivak@redhat.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div class="m_-7903319557425054007gmail-m_-2217787408152018609m_-3331247846607507906m_5190463728797355581h5">Hi,<br>
<br>
I just got a question from an ovirt-optimizer user about the support<br>
in 4.2. And I realized I haven't heard anything about how UI plugins<br>
should be updated to work with the new UI.<br>
<br>
Is there anything special that needs to be done to make the plugin<br>
functional? Or will everything still work somehow?<br>
<br>
Best regards<br>
</div></div><span class="m_-7903319557425054007gmail-m_-2217787408152018609m_-3331247846607507906m_5190463728797355581m_-6414561921489680629gmail-HOEnZb"><font color="#888888"><br>
Martin Sivak<br>
______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a><br>
</font></span></blockquote></div><br><div class="m_-7903319557425054007gmail-m_-2217787408152018609m_-3331247846607507906m_5190463728797355581m_-6414561921489680629gmail_signature"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><br></div></div></div></div></div>
</div></div></div></div></div></div></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br><br clear="all"><div><br></div></div></div><span class="m_-7903319557425054007gmail-m_-2217787408152018609HOEnZb"><font color="#888888">-- <br><div class="m_-7903319557425054007gmail-m_-2217787408152018609m_-3331247846607507906gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase"><span>GREG</span> <span>SHEREMETA</span></p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase"><span>SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX</span><span style="color:rgb(170,170,170);margin:0px"></span></p><p style="font-family:overpass,sans-serif;margin:0px;font-size:10px;color:rgb(153,153,153)"><a href="https://www.redhat.com/" style="color:rgb(0,136,206);margin:0px" target="_blank">Red Hat NA<span><br><br></span></a></p><p style="font-family:overpass,sans-serif;margin:0px 0px 6px;font-size:10px;color:rgb(153,153,153)"><span style="margin:0px;padding:0px"><a href="mailto:gshereme@redhat.com" style="color:rgb(0,136,206);margin:0px" target="_blank">gshereme@redhat.com</a> </span> <span>IRC: <span>gshereme</span></span></p><table border="0" style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium"><tbody><tr><td width="100px"><a href="https://red.ht/sig" target="_blank"><img src="https://www.redhat.com/files/brand/email/sig-redhat.png" width="90" height="auto"></a></td></tr></tbody></table></div></div></div></div></div></div></div></div></div>
</font></span></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="m_-7903319557425054007gmail-m_-2217787408152018609gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase"><span>GREG</span> <span>SHEREMETA</span></p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase"><span>SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX</span><span style="color:rgb(170,170,170);margin:0px"></span></p><p style="font-family:overpass,sans-serif;margin:0px;font-size:10px;color:rgb(153,153,153)"><a href="https://www.redhat.com/" style="color:rgb(0,136,206);margin:0px" target="_blank">Red Hat NA<span><br><br></span></a></p><p style="font-family:overpass,sans-serif;margin:0px 0px 6px;font-size:10px;color:rgb(153,153,153)"><span style="margin:0px;padding:0px"><a href="mailto:gshereme@redhat.com" style="color:rgb(0,136,206);margin:0px" target="_blank">gshereme@redhat.com</a> </span> <span>IRC: <span>gshereme</span></span></p><table border="0" style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium"><tbody><tr><td width="100px"><a href="https://red.ht/sig" target="_blank"><img src="https://www.redhat.com/files/brand/email/sig-redhat.png" width="90" height="auto"></a></td></tr></tbody></table></div></div></div></div></div></div></div></div></div>
</div></div></div></div></div>
</blockquote></div><br></div>