<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Hello Martin,</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">UI plugin API in 4.2 should be generally backwards compatible with 4.1.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Comparing PluginManager.java between master and 4.1.8 - the exposePluginApi() function is exactly the same for now.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">However, we might do some API changes in the future, mainly due to 4.2 UI redesign. For example:</div><div class="gmail_default"><ul><li>taking out the word "Tab" out of function names, since the UI concept of "main tab" is no more</li><li>as mentioned by Alex, support adding buttons inside kebab drop-down, as opposed to adding them directly to the toolbar (UX wise, important things should be outside kebab, less important things should go inside it)<br></li><li>support adding secondary level menu items when adding new "main tab" (this should become "add menu item" function)</li><li>support customizing the icon for primary menu items</li></ul></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">As for the visuals, as Greg wrote, UI plugins should generally follow the PatternFly styling to ensure consistent looks.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">WebAdmin has its own branding infra and UI plugins can use that. Just inspect the HTML source and see how WebAdmin requests PatternFly & branding related assets.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Vojtech</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Nov 29, 2017 at 1:22 AM, Greg Sheremeta <span dir="ltr"><<a href="mailto:gshereme@redhat.com" target="_blank">gshereme@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hey,<div><br></div><div>We haven't changed the API, so everything should still work. For example, I just installed 4.1 versions of dashboard and support-plugin in master, and all's well [*]:<div><br></div><div>API:</div><div><br></div><div><div>api.addSubTab('Template', 'Red Hat Documentation', 'my-host-subtab-template', '<url snip>', {alignRight: true});</div><div>api.setTabAccessible('my-host-<wbr>subtab-template', true);</div><div><br></div><div><img src="cid:ii_160051f196581285" alt="Inline image 1" width="539" height="66"><br></div><div><br></div><div>[*] however, note that "alignRight" is now ignored<br></div><div><br></div><div>And dashboard 4.1.8 installed in master engine:</div><div><br></div><div><img src="cid:ii_160052092345cad7" alt="Inline image 2" width="539" height="290"><br></div><div><br></div><div><div><br></div><div>That said, we probably should have sent some announcement about making sure the plugins actually look good with the new theme. If some plugins are greenish, that will look bad.</div><div><br></div><div>To help with styling external things, we've started exposing more CSS via a new SASS brand module:</div><div><a href="https://github.com/oVirt/ovirt-engine/tree/master/frontend/brands/ovirt-brand/src/main/sass" target="_blank">https://github.com/oVirt/<wbr>ovirt-engine/tree/master/<wbr>frontend/brands/<div class="gmail_default" style="font-family:arial,helvetica,sans-serif;display:inline"></div>ovirt-brand/<wbr>src/main/sass</a></div><div>Also, we're heavily relying on base PatternFly styles, and plugins should do the same. For example, the new dialog styles are completely PatternFly [<a href="http://www.patternfly.org/pattern-library/forms-and-controls/modal-overlay/" target="_blank">http://www.patternfly.org/<wbr>pattern-library/forms-and-<wbr>controls/modal-overlay/</a>] and we don't do anything extra on top of that.<br><div><br></div><div>Let us know if something doesn't work, or you need help styling something.</div><div><br></div><div>Greg</div><div><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="gmail-h5">On Tue, Nov 28, 2017 at 6:25 PM, Martin Sivak <span dir="ltr"><<a href="mailto:msivak@redhat.com" target="_blank">msivak@redhat.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div class="gmail-h5">Hi,<br>
<br>
I just got a question from an ovirt-optimizer user about the support<br>
in 4.2. And I realized I haven't heard anything about how UI plugins<br>
should be updated to work with the new UI.<br>
<br>
Is there anything special that needs to be done to make the plugin<br>
functional? Or will everything still work somehow?<br>
<br>
Best regards<br>
</div></div><span class="gmail-m_-888526326325739149gmail-HOEnZb"><font color="#888888"><br>
Martin Sivak<br>
______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a><br>
</font></span></blockquote></div><br><div class="gmail-m_-888526326325739149gmail_signature"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><br></div></div></div></div></div>
</div></div></div></div></div></div></div>
</blockquote></div><br></div></div>