<div dir="ltr">It stays on a single line with just slightly wider window than I normally have. But all plugins will be adding buttons here so the line can theoretically get really long.<div><br></div><div>Btw, is 1920px the required resolution now? Because I have no screen or machine with that :D</div><div><br></div><div>Martin</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Nov 30, 2017 at 4:44 PM, Greg Sheremeta <span dir="ltr"><<a href="mailto:gshereme@redhat.com" target="_blank">gshereme@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">How does it look at 1920px wide?<div><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Nov 30, 2017 at 10:40 AM, Martin Sivak <span dir="ltr"><<a href="mailto:msivak@redhat.com" target="_blank">msivak@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi,<div><br></div><div>I see it working with a small UI glitch:</div><div><br></div><div>Martin</div></div><div class="m_-4592087223676711936HOEnZb"><div class="m_-4592087223676711936h5"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Nov 29, 2017 at 6:25 PM, Martin Sivak <span dir="ltr"><<a href="mailto:msivak@redhat.com" target="_blank">msivak@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I will try finding time tomorrow. Thanks.<span class="m_-4592087223676711936m_-242746470338262019HOEnZb"><font color="#888888"><div><br></div><div>Martin</div></font></span></div><div class="m_-4592087223676711936m_-242746470338262019HOEnZb"><div class="m_-4592087223676711936m_-242746470338262019h5"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Nov 29, 2017 at 6:02 PM, Greg Sheremeta <span dir="ltr"><<a href="mailto:gshereme@redhat.com" target="_blank">gshereme@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Martin, we've merged the fix. (Thanks to Alexander for the super fast fix.)<div><br></div><div>Care to test with master?<br><div class="gmail_extra"><div><div class="m_-4592087223676711936m_-242746470338262019m_4413693146269115269h5"><br><div class="gmail_quote">On Wed, Nov 29, 2017 at 10:50 AM, Alexander Wels <span dir="ltr"><<a href="mailto:awels@redhat.com" target="_blank">awels@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>On Wednesday, November 29, 2017 10:16:27 AM EST Martin Sivak wrote:<br>
> Thanks to you too for checking.<br>
><br>
> Martin<br>
><br>
<br>
</span>Fix is pending review [1]. We moved the main views to a different class<br>
hierarchy and it wasn't inheriting the methods to add the buttons.<br>
<br>
Alexander<br>
<br>
[1] <a href="https://gerrit.ovirt.org/c/84901/" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/c/849<wbr>01/</a><br>
<div><div class="m_-4592087223676711936m_-242746470338262019m_4413693146269115269m_2947628347571662041h5"><br>
> On Wed, Nov 29, 2017 at 3:07 PM, Greg Sheremeta <<a href="mailto:gshereme@redhat.com" target="_blank">gshereme@redhat.com</a>> wrote:<br>
> > Discussed with Alexander, and yep this is an issue.<br>
> > I opened <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1518724" rel="noreferrer" target="_blank">https://bugzilla.redhat.com/sh<wbr>ow_bug.cgi?id=1518724</a><br>
> ><br>
> > Thanks for checking and reporting!<br>
> ><br>
> > On Wed, Nov 29, 2017 at 8:35 AM, Greg Sheremeta <<a href="mailto:gshereme@redhat.com" target="_blank">gshereme@redhat.com</a>><br>
> ><br>
> > wrote:<br>
> >> +Alexander, can you take a look?<br>
> >><br>
> >> On Wed, Nov 29, 2017 at 8:33 AM, Martin Sivak <<a href="mailto:msivak@redhat.com" target="_blank">msivak@redhat.com</a>> wrote:<br>
> >>> Hi,<br>
> >>><br>
> >>> I think I found one issue.. I do not see the extra menu items that were<br>
> >>> supposed to be added to VMs (used to be available in context menu as<br>
> >>> well).<br>
> >>><br>
> >>> You can check it with<br>
> >>><br>
> >>> <a href="http://jenkins.ovirt.org/job/ovirt-optimizer_master_check-pa" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/job/o<wbr>virt-optimizer_master_check-pa</a><br>
> >>> tch-el7-x86_64/65/<br>
> >>><br>
> >>> Martin<br>
> >>><br>
> >>> On Wed, Nov 29, 2017 at 1:22 AM, Greg Sheremeta <<a href="mailto:gshereme@redhat.com" target="_blank">gshereme@redhat.com</a>><br>
> >>><br>
> >>> wrote:<br>
> >>>> Hey,<br>
> >>>><br>
> >>>> We haven't changed the API, so everything should still work. For<br>
> >>>> example, I just installed 4.1 versions of dashboard and support-plugin<br>
> >>>> in<br>
> >>>> master, and all's well [*]:<br>
> >>>><br>
> >>>> API:<br>
> >>>><br>
> >>>> api.addSubTab('Template', 'Red Hat Documentation',<br>
> >>>> 'my-host-subtab-template', '<url snip>', {alignRight: true});<br>
> >>>> api.setTabAccessible('my-host-<wbr>subtab-template', true);<br>
> >>>><br>
> >>>> [image: Inline image 1]<br>
> >>>><br>
> >>>> [*] however, note that "alignRight" is now ignored<br>
> >>>><br>
> >>>> And dashboard 4.1.8 installed in master engine:<br>
> >>>><br>
> >>>> [image: Inline image 2]<br>
> >>>><br>
> >>>><br>
> >>>> That said, we probably should have sent some announcement about making<br>
> >>>> sure the plugins actually look good with the new theme. If some plugins<br>
> >>>> are<br>
> >>>> greenish, that will look bad.<br>
> >>>><br>
> >>>> To help with styling external things, we've started exposing more CSS<br>
> >>>> via a new SASS brand module:<br>
> >>>> <a href="https://github.com/oVirt/ovirt-engine/tree/master/frontend/b" rel="noreferrer" target="_blank">https://github.com/oVirt/ovirt<wbr>-engine/tree/master/frontend/b</a><br>
> >>>> rands/ovirt-brand/src/main/sas<wbr>s<br>
> >>>> Also, we're heavily relying on base PatternFly styles, and plugins<br>
> >>>> should do the same. For example, the new dialog styles are completely<br>
> >>>> PatternFly [<a href="http://www.patternfly.org/pattern-library/forms-and-control" rel="noreferrer" target="_blank">http://www.patternfly.org/pat<wbr>tern-library/forms-and-control</a><br>
> >>>> s/modal-overlay/] and we don't do anything extra on top of that.<br>
> >>>><br>
> >>>> Let us know if something doesn't work, or you need help styling<br>
> >>>> something.<br>
> >>>><br>
> >>>> Greg<br>
> >>>><br>
> >>>> On Tue, Nov 28, 2017 at 6:25 PM, Martin Sivak <<a href="mailto:msivak@redhat.com" target="_blank">msivak@redhat.com</a>><br>
> >>>><br>
> >>>> wrote:<br>
> >>>>> Hi,<br>
> >>>>><br>
> >>>>> I just got a question from an ovirt-optimizer user about the support<br>
> >>>>> in 4.2. And I realized I haven't heard anything about how UI plugins<br>
> >>>>> should be updated to work with the new UI.<br>
> >>>>><br>
> >>>>> Is there anything special that needs to be done to make the plugin<br>
> >>>>> functional? Or will everything still work somehow?<br>
> >>>>><br>
> >>>>> Best regards<br>
> >>>>><br>
> >>>>> Martin Sivak<br>
> >>>>> ______________________________<wbr>_________________<br>
> >>>>> Devel mailing list<br>
> >>>>> <a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
> >>>>> <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a><br>
> >><br>
> >> --<br>
> >><br>
> >> GREG SHEREMETA<br>
> >><br>
> >> SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX<br>
> >><br>
> >> Red Hat NA<br>
> >><br>
</div></div>> >> <<a href="https://www.redhat.com/" rel="noreferrer" target="_blank">https://www.redhat.com/</a>><br>
> >><br>
> >> <a href="mailto:gshereme@redhat.com" target="_blank">gshereme@redhat.com</a> IRC: gshereme<br>
> >> <<a href="https://red.ht/sig" rel="noreferrer" target="_blank">https://red.ht/sig</a>><br>
<span>> ><br>
> > --<br>
> ><br>
> > GREG SHEREMETA<br>
> ><br>
> > SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX<br>
> ><br>
> > Red Hat NA<br>
> ><br>
</span>> > <<a href="https://www.redhat.com/" rel="noreferrer" target="_blank">https://www.redhat.com/</a>><br>
> ><br>
> > <a href="mailto:gshereme@redhat.com" target="_blank">gshereme@redhat.com</a> IRC: gshereme<br>
> > <<a href="https://red.ht/sig" rel="noreferrer" target="_blank">https://red.ht/sig</a>><br>
<br>
<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br></div></div><div class="m_-4592087223676711936m_-242746470338262019m_4413693146269115269m_2947628347571662041gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div><div class="m_-4592087223676711936m_-242746470338262019m_4413693146269115269h5"><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase"><span>GREG</span> <span>SHEREMETA</span></p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase"><span>SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX</span><span style="color:rgb(170,170,170);margin:0px"></span></p><p style="font-family:overpass,sans-serif;margin:0px;font-size:10px;color:rgb(153,153,153)"><a href="https://www.redhat.com/" style="color:rgb(0,136,206);margin:0px" target="_blank">Red Hat NA<span><br><br></span></a></p></div></div><p style="font-family:overpass,sans-serif;margin:0px 0px 6px;font-size:10px;color:rgb(153,153,153)"><span style="margin:0px;padding:0px"><a href="mailto:gshereme@redhat.com" style="color:rgb(0,136,206);margin:0px" target="_blank">gshereme@redhat.com</a> </span> <span>IRC: <span>gshereme</span></span></p><table border="0" style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium"><tbody><tr><td width="100px"><a href="https://red.ht/sig" target="_blank"><img src="https://www.redhat.com/files/brand/email/sig-redhat.png" width="90" height="auto"></a></td></tr></tbody></table></div></div></div></div></div></div></div></div></div>
</div></div></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="m_-4592087223676711936gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase"><span>GREG</span> <span>SHEREMETA</span></p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase"><span>SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX</span><span style="color:rgb(170,170,170);margin:0px"></span></p><p style="font-family:overpass,sans-serif;margin:0px;font-size:10px;color:rgb(153,153,153)"><a href="https://www.redhat.com/" style="color:rgb(0,136,206);margin:0px" target="_blank">Red Hat NA<span><br><br></span></a></p><p style="font-family:overpass,sans-serif;margin:0px 0px 6px;font-size:10px;color:rgb(153,153,153)"><span style="margin:0px;padding:0px"><a href="mailto:gshereme@redhat.com" style="color:rgb(0,136,206);margin:0px" target="_blank">gshereme@redhat.com</a> </span> <span>IRC: <span>gshereme</span></span></p><table border="0" style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium"><tbody><tr><td width="100px"><a href="https://red.ht/sig" target="_blank"><img src="https://www.redhat.com/files/brand/email/sig-redhat.png" width="90" height="auto"></a></td></tr></tbody></table></div></div></div></div></div></div></div></div></div>
</div></div></div></div>
</blockquote></div><br></div>