<div dir="ltr">And if you try clicking the kebab when it's wrapped, it's overlapped by the left nav (reported by Lucie, targeted for 4.2.1)<div><br></div><div><img src="cid:ii_1600db72a285235c" alt="Inline image 1" width="539" height="356"><br><div><br></div><div>Anyway, thanks for reporting. Alexander will fix it somehow I'm sure :D</div><div><br></div><div>Greg<br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Nov 30, 2017 at 10:56 AM, Alexander Wels <span dir="ltr"><<a href="mailto:awels@redhat.com" target="_blank">awels@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Thursday, November 30, 2017 10:48:26 AM EST Martin Sivak wrote:<br>
> It stays on a single line with just slightly wider window than I normally<br>
> have. But all plugins will be adding buttons here so the line can<br>
> theoretically get really long.<br>
><br>
> Btw, is 1920px the required resolution now? Because I have no screen or<br>
> machine with that :D<br>
><br>
> Martin<br>
><br>
<br>
</span>Right and we have no api option (yet) to allow plugins to put their buttons in<br>
the kebab menu. The buttons (and kebab as you noticed) will simply wrap to the<br>
next line if there is not enough space to display them all. You just happened<br>
to have a width where just the kebab menu wrapped, which looks sort of weird.<br>
I guess we can try to force the kebab on the top right regardless of if the<br>
buttons wrap.<br>
<br>
Btw there is no resolution requirement. In fact it should be somewhat usable<br>
on low resolution and mobile type screens now.<br>
<div class="HOEnZb"><div class="h5"><br>
> On Thu, Nov 30, 2017 at 4:44 PM, Greg Sheremeta <<a href="mailto:gshereme@redhat.com">gshereme@redhat.com</a>> wrote:<br>
> > How does it look at 1920px wide?<br>
> ><br>
> > On Thu, Nov 30, 2017 at 10:40 AM, Martin Sivak <<a href="mailto:msivak@redhat.com">msivak@redhat.com</a>> wrote:<br>
> >> Hi,<br>
> >><br>
> >> I see it working with a small UI glitch:<br>
> >><br>
> >> Martin<br>
> >><br>
> >> On Wed, Nov 29, 2017 at 6:25 PM, Martin Sivak <<a href="mailto:msivak@redhat.com">msivak@redhat.com</a>> wrote:<br>
> >>> I will try finding time tomorrow. Thanks.<br>
> >>><br>
> >>> Martin<br>
> >>><br>
> >>> On Wed, Nov 29, 2017 at 6:02 PM, Greg Sheremeta <<a href="mailto:gshereme@redhat.com">gshereme@redhat.com</a>><br>
> >>><br>
> >>> wrote:<br>
> >>>> Martin, we've merged the fix. (Thanks to Alexander for the super fast<br>
> >>>> fix.)<br>
> >>>><br>
> >>>> Care to test with master?<br>
> >>>><br>
> >>>> On Wed, Nov 29, 2017 at 10:50 AM, Alexander Wels <<a href="mailto:awels@redhat.com">awels@redhat.com</a>><br>
> >>>><br>
> >>>> wrote:<br>
> >>>>> On Wednesday, November 29, 2017 10:16:27 AM EST Martin Sivak wrote:<br>
> >>>>> > Thanks to you too for checking.<br>
> >>>>> ><br>
> >>>>> > Martin<br>
> >>>>><br>
> >>>>> Fix is pending review [1]. We moved the main views to a different<br>
> >>>>> class<br>
> >>>>> hierarchy and it wasn't inheriting the methods to add the buttons.<br>
> >>>>><br>
> >>>>> Alexander<br>
> >>>>><br>
> >>>>> [1] <a href="https://gerrit.ovirt.org/c/84901/" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/c/<wbr>84901/</a><br>
> >>>>><br>
> >>>>> > On Wed, Nov 29, 2017 at 3:07 PM, Greg Sheremeta<br>
> >>>>> > <<a href="mailto:gshereme@redhat.com">gshereme@redhat.com</a>><br>
> >>>>><br>
> >>>>> wrote:<br>
> >>>>> > > Discussed with Alexander, and yep this is an issue.<br>
> >>>>> > > I opened <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1518724" rel="noreferrer" target="_blank">https://bugzilla.redhat.com/<wbr>show_bug.cgi?id=1518724</a><br>
> >>>>> > ><br>
> >>>>> > > Thanks for checking and reporting!<br>
> >>>>> > ><br>
> >>>>> > > On Wed, Nov 29, 2017 at 8:35 AM, Greg Sheremeta <<br>
> >>>>><br>
> >>>>> <a href="mailto:gshereme@redhat.com">gshereme@redhat.com</a>><br>
> >>>>><br>
> >>>>> > > wrote:<br>
> >>>>> > >> +Alexander, can you take a look?<br>
> >>>>> > >><br>
> >>>>> > >> On Wed, Nov 29, 2017 at 8:33 AM, Martin Sivak <<a href="mailto:msivak@redhat.com">msivak@redhat.com</a>><br>
> >>>>><br>
> >>>>> wrote:<br>
> >>>>> > >>> Hi,<br>
> >>>>> > >>><br>
> >>>>> > >>> I think I found one issue.. I do not see the extra menu items<br>
> >>>>><br>
> >>>>> that were<br>
> >>>>><br>
> >>>>> > >>> supposed to be added to VMs (used to be available in context<br>
> >>>>><br>
> >>>>> menu as<br>
> >>>>><br>
> >>>>> > >>> well).<br>
> >>>>> > >>><br>
> >>>>> > >>> You can check it with<br>
> >>>>> > >>><br>
> >>>>> > >>> <a href="http://jenkins.ovirt.org/job/ovirt-optimizer_master_check-pa" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/job/<wbr>ovirt-optimizer_master_check-<wbr>pa</a><br>
> >>>>> > >>> tch-el7-x86_64/65/<br>
> >>>>> > >>><br>
> >>>>> > >>> Martin<br>
> >>>>> > >>><br>
> >>>>> > >>> On Wed, Nov 29, 2017 at 1:22 AM, Greg Sheremeta <<br>
> >>>>><br>
> >>>>> <a href="mailto:gshereme@redhat.com">gshereme@redhat.com</a>><br>
> >>>>><br>
> >>>>> > >>> wrote:<br>
> >>>>> > >>>> Hey,<br>
> >>>>> > >>>><br>
> >>>>> > >>>> We haven't changed the API, so everything should still work.<br>
> >>>>> > >>>> For<br>
> >>>>> > >>>> example, I just installed 4.1 versions of dashboard and<br>
> >>>>><br>
> >>>>> support-plugin<br>
> >>>>><br>
> >>>>> > >>>> in<br>
> >>>>> > >>>> master, and all's well [*]:<br>
> >>>>> > >>>><br>
> >>>>> > >>>> API:<br>
> >>>>> > >>>><br>
> >>>>> > >>>> api.addSubTab('Template', 'Red Hat Documentation',<br>
> >>>>> > >>>> 'my-host-subtab-template', '<url snip>', {alignRight: true});<br>
> >>>>> > >>>> api.setTabAccessible('my-host-<wbr>subtab-template', true);<br>
> >>>>> > >>>><br>
> >>>>> > >>>> [image: Inline image 1]<br>
> >>>>> > >>>><br>
> >>>>> > >>>> [*] however, note that "alignRight" is now ignored<br>
> >>>>> > >>>><br>
> >>>>> > >>>> And dashboard 4.1.8 installed in master engine:<br>
> >>>>> > >>>><br>
> >>>>> > >>>> [image: Inline image 2]<br>
> >>>>> > >>>><br>
> >>>>> > >>>><br>
> >>>>> > >>>> That said, we probably should have sent some announcement about<br>
> >>>>><br>
> >>>>> making<br>
> >>>>><br>
> >>>>> > >>>> sure the plugins actually look good with the new theme. If some<br>
> >>>>><br>
> >>>>> plugins<br>
> >>>>><br>
> >>>>> > >>>> are<br>
> >>>>> > >>>> greenish, that will look bad.<br>
> >>>>> > >>>><br>
> >>>>> > >>>> To help with styling external things, we've started exposing<br>
> >>>>><br>
> >>>>> more CSS<br>
> >>>>><br>
> >>>>> > >>>> via a new SASS brand module:<br>
> >>>>> > >>>> <a href="https://github.com/oVirt/ovirt-engine/tree/master/frontend/b" rel="noreferrer" target="_blank">https://github.com/oVirt/<wbr>ovirt-engine/tree/master/<wbr>frontend/b</a><br>
> >>>>> > >>>> rands/ovirt-brand/src/main/<wbr>sass<br>
> >>>>> > >>>> Also, we're heavily relying on base PatternFly styles, and<br>
> >>>>><br>
> >>>>> plugins<br>
> >>>>><br>
> >>>>> > >>>> should do the same. For example, the new dialog styles are<br>
> >>>>><br>
> >>>>> completely<br>
> >>>>><br>
> >>>>> > >>>> PatternFly [<a href="http://www.patternfly.org/pat" rel="noreferrer" target="_blank">http://www.patternfly.org/pat</a><br>
> >>>>><br>
> >>>>> tern-library/forms-and-control<br>
> >>>>><br>
> >>>>> > >>>> s/modal-overlay/] and we don't do anything extra on top of<br>
> >>>>> > >>>> that.<br>
> >>>>> > >>>><br>
> >>>>> > >>>> Let us know if something doesn't work, or you need help styling<br>
> >>>>> > >>>> something.<br>
> >>>>> > >>>><br>
> >>>>> > >>>> Greg<br>
> >>>>> > >>>><br>
> >>>>> > >>>> On Tue, Nov 28, 2017 at 6:25 PM, Martin Sivak <<br>
> >>>>><br>
> >>>>> <a href="mailto:msivak@redhat.com">msivak@redhat.com</a>><br>
> >>>>><br>
> >>>>> > >>>> wrote:<br>
> >>>>> > >>>>> Hi,<br>
> >>>>> > >>>>><br>
> >>>>> > >>>>> I just got a question from an ovirt-optimizer user about the<br>
> >>>>><br>
> >>>>> support<br>
> >>>>><br>
> >>>>> > >>>>> in 4.2. And I realized I haven't heard anything about how UI<br>
> >>>>><br>
> >>>>> plugins<br>
> >>>>><br>
> >>>>> > >>>>> should be updated to work with the new UI.<br>
> >>>>> > >>>>><br>
> >>>>> > >>>>> Is there anything special that needs to be done to make the<br>
> >>>>><br>
> >>>>> plugin<br>
> >>>>><br>
> >>>>> > >>>>> functional? Or will everything still work somehow?<br>
> >>>>> > >>>>><br>
> >>>>> > >>>>> Best regards<br>
> >>>>> > >>>>><br>
> >>>>> > >>>>> Martin Sivak<br>
> >>>>> > >>>>> ______________________________<wbr>_________________<br>
> >>>>> > >>>>> Devel mailing list<br>
> >>>>> > >>>>> <a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
> >>>>> > >>>>> <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/devel</a><br>
> >>>>> > >><br>
> >>>>> > >> --<br>
> >>>>> > >><br>
> >>>>> > >> GREG SHEREMETA<br>
> >>>>> > >><br>
> >>>>> > >> SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX<br>
> >>>>> > >><br>
> >>>>> > >> Red Hat NA<br>
> >>>>> > >><br>
> >>>>> > >> <<a href="https://www.redhat.com/" rel="noreferrer" target="_blank">https://www.redhat.com/</a>><br>
> >>>>> > >><br>
> >>>>> > >> <a href="mailto:gshereme@redhat.com">gshereme@redhat.com</a> IRC: gshereme<br>
> >>>>> > >> <<a href="https://red.ht/sig" rel="noreferrer" target="_blank">https://red.ht/sig</a>><br>
> >>>>> > ><br>
> >>>>> > > --<br>
> >>>>> > ><br>
> >>>>> > > GREG SHEREMETA<br>
> >>>>> > ><br>
> >>>>> > > SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX<br>
> >>>>> > ><br>
> >>>>> > > Red Hat NA<br>
> >>>>> > ><br>
> >>>>> > > <<a href="https://www.redhat.com/" rel="noreferrer" target="_blank">https://www.redhat.com/</a>><br>
> >>>>> > ><br>
> >>>>> > > <a href="mailto:gshereme@redhat.com">gshereme@redhat.com</a> IRC: gshereme<br>
> >>>>> > > <<a href="https://red.ht/sig" rel="noreferrer" target="_blank">https://red.ht/sig</a>><br>
> >>>><br>
> >>>> --<br>
> >>>><br>
> >>>> GREG SHEREMETA<br>
> >>>><br>
> >>>> SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX<br>
> >>>><br>
> >>>> Red Hat NA<br>
> >>>><br>
> >>>> <<a href="https://www.redhat.com/" rel="noreferrer" target="_blank">https://www.redhat.com/</a>><br>
> >>>><br>
> >>>> <a href="mailto:gshereme@redhat.com">gshereme@redhat.com</a> IRC: gshereme<br>
> >>>> <<a href="https://red.ht/sig" rel="noreferrer" target="_blank">https://red.ht/sig</a>><br>
> ><br>
> > --<br>
> ><br>
> > GREG SHEREMETA<br>
> ><br>
> > SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX<br>
> ><br>
> > Red Hat NA<br>
> ><br>
> > <<a href="https://www.redhat.com/" rel="noreferrer" target="_blank">https://www.redhat.com/</a>><br>
> ><br>
> > <a href="mailto:gshereme@redhat.com">gshereme@redhat.com</a> IRC: gshereme<br>
> > <<a href="https://red.ht/sig" rel="noreferrer" target="_blank">https://red.ht/sig</a>><br>
<br>
<br>
</div></div></blockquote></div><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><br></div></div></div></div></div>
</div></div></div></div>