<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Dec 8, 2017 at 11:20 PM, Yaniv Kaul <span dir="ltr"><<a href="mailto:ykaul@redhat.com" target="_blank">ykaul@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span>On Fri, Dec 8, 2017 at 10:39 PM, Yaniv Kaul <span dir="ltr"><<a href="mailto:ykaul@redhat.com" target="_blank">ykaul@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="gmail-m_3164322619143296411m_8268433748796977447gmail-">On Fri, Dec 8, 2017 at 9:31 PM, Dafna Ron <span dir="ltr"><<a href="mailto:dron@redhat.com" target="_blank">dron@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div bgcolor="#FFFFFF">
<div class="gmail-m_3164322619143296411m_8268433748796977447gmail-m_-4266418101369303823gmail-m_-474056254907482480moz-cite-prefix">I opened a bug:
<a class="gmail-m_3164322619143296411m_8268433748796977447gmail-m_-4266418101369303823gmail-m_-474056254907482480moz-txt-link-freetext" href="https://bugzilla.redhat.com/show_bug.cgi?id=1523813" target="_blank">https://bugzilla.redhat.com/sh<wbr>ow_bug.cgi?id=1523813</a></div></div></blockquote><div><br></div></span><div>I'm optimistically hoping <a href="https://gerrit.ovirt.org/#/c/85195/" target="_blank">https://gerrit.ovirt.or<wbr>g/#/c/85195/</a> will fix it.</div><div>Not sure.</div></div></div></div></blockquote><div><br></div></span><div>Keeps failing with:</div><div>Operation Failed: [Cannot deactivate Storage. The relevant Storage Domain's status is Maintenance.] </div><div><br></div><div>Which is strange:</div><div>1. I do check if the SD is in Maint. mode before trying to deactive and the test is supposed to be skipped if it is.</div></div></div></div></blockquote><div><br></div><div>I've added a comment in the patch,</div><div>I suspect it is related to the fact that we fetch the domain from storage_domains and not attached_storage_domains</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>2. Why can't I deactive a SD when in Maint. mode?</div></div></div></div></blockquote><div><br></div><div>I assume that the engine fails since that means that the storage domain is not connected to the Host and the execute phase of maintenance performs operations like update ovf store which depend on the storage domain to be connected.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><div>Probably missing something here.</div><span class="gmail-m_3164322619143296411HOEnZb"><font color="#888888"><div>Y.</div></font></span><div><div class="gmail-m_3164322619143296411h5"><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class="gmail-m_3164322619143296411m_8268433748796977447gmail-HOEnZb"><font color="#888888"><div>Y.</div></font></span><div><div class="gmail-m_3164322619143296411m_8268433748796977447gmail-h5"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div bgcolor="#FFFFFF"><div class="gmail-m_3164322619143296411m_8268433748796977447gmail-m_-4266418101369303823gmail-m_-474056254907482480moz-cite-prefix"><br>
Allon, can you please assign someone to help fix this test? <br>
Please let me know if you need help from me. <br>
<br>
Thanks!<span class="gmail-m_3164322619143296411m_8268433748796977447gmail-m_-4266418101369303823gmail-HOEnZb"><font color="#888888"><br>
Dafna</font></span><div><div class="gmail-m_3164322619143296411m_8268433748796977447gmail-m_-4266418101369303823gmail-h5"><br></div></div></div></div></blockquote></div></div></div></div></div></blockquote></div></div></div></div></div></blockquote><div><br></div><div>Thanks Dafna, besides the fix which should be done in the OST, here is an old old bug which might also become useful:</div><div> <a href="https://bugzilla.redhat.com/show_bug.cgi?id=879248" target="_blank" style="font-family:monospace,monospace">https://bugzilla.redhat.com/879248</a><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div class="gmail-m_3164322619143296411h5"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div class="gmail-m_3164322619143296411m_8268433748796977447gmail-h5"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div bgcolor="#FFFFFF"><div class="gmail-m_3164322619143296411m_8268433748796977447gmail-m_-4266418101369303823gmail-m_-474056254907482480moz-cite-prefix"><div><div class="gmail-m_3164322619143296411m_8268433748796977447gmail-m_-4266418101369303823gmail-h5">
<br>
<br>
On 12/07/2017 11:59 AM, Yaniv Kaul wrote:<br>
</div></div></div><div><div class="gmail-m_3164322619143296411m_8268433748796977447gmail-m_-4266418101369303823gmail-h5">
<blockquote type="cite">
<div dir="ltr"><br>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Thu, Dec 7, 2017 at 1:30 PM, Eyal
Shenitzky <span dir="ltr"><<a href="mailto:eshenitz@redhat.com" target="_blank">eshenitz@redhat.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr">I think that the maybe the QE can share
their methods on how to avoid those issues.
<div>From what I remember, before deactivating storage
domain they make sure that there are no running tasks
related to</div>
<div>the storage domain.</div>
</div>
</blockquote>
<div><br>
</div>
<div>Looks like an easy fix is to wrap it with try, except
sdk4.Error and let it sit within the
testlib.assert_true_within_sho<wbr>rt() loop.</div>
<div>Y.</div>
<div> </div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div class="gmail_extra">
<div>
<div class="gmail-m_3164322619143296411m_8268433748796977447gmail-m_-4266418101369303823gmail-m_-474056254907482480h5"><br>
<div class="gmail_quote">On Thu, Dec 7, 2017 at 1:22
PM, Yaniv Kaul <span dir="ltr"><<a href="mailto:ykaul@redhat.com" target="_blank">ykaul@redhat.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr"><br>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Thu, Dec 7, 2017
at 1:12 PM, Dafna Ron <span dir="ltr"><<a href="mailto:dron@redhat.com" target="_blank">dron@redhat.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div bgcolor="#FFFFFF">
<div class="gmail-m_3164322619143296411m_8268433748796977447gmail-m_-4266418101369303823gmail-m_-474056254907482480m_8942236351456563473m_-5014669676915136678m_3333631383734454308moz-cite-prefix">Maor,
I either need to get new glasses or
a magnifier glass to read what you
wrote :-P<br>
when you say running tasks - these
are actually running tasks that may
be running because of other tests in
ost - correct? wouldn't killing or
blocking those can cause other tests
to fail? <br>
</div>
</div>
</blockquote>
<div><br>
</div>
<div>It might well be the OVF update. How
can we, from the API, wait for those
tasks to complete? Or should we catch
exception and retry?</div>
<div>Y.</div>
<div> </div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div bgcolor="#FFFFFF">
<div class="gmail-m_3164322619143296411m_8268433748796977447gmail-m_-4266418101369303823gmail-m_-474056254907482480m_8942236351456563473m_-5014669676915136678m_3333631383734454308moz-cite-prefix">
<div>
<div class="gmail-m_3164322619143296411m_8268433748796977447gmail-m_-4266418101369303823gmail-m_-474056254907482480m_8942236351456563473m_-5014669676915136678h5">
<br>
On 12/07/2017 11:06 AM, Maor
Lipchuk wrote:<br>
</div>
</div>
</div>
<div>
<div class="gmail-m_3164322619143296411m_8268433748796977447gmail-m_-4266418101369303823gmail-m_-474056254907482480m_8942236351456563473m_-5014669676915136678h5">
<blockquote type="cite">
<div dir="ltr"><span id="gmail-m_3164322619143296411m_8268433748796977447gmail-m_-4266418101369303823gmail-m_-474056254907482480m_8942236351456563473m_-5014669676915136678m_3333631383734454308gmail-m_-5329876534188665956docs-internal-guid-5859b7a1-3073-5414-18b7-2d31991889e8">
<p style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="background-color:transparent;vertical-align:baseline"><span style="color:rgb(0,0,0);font-family:monospace;white-space:pre-wrap">CANNOT_DEACTIVATE_DOMAIN_WITH_</span><span style="color:rgb(0,0,0);font-family:monospace;white-space:pre-wrap"><wbr>TASKS </span><font><font color="#000000" size="1" face="Arial"><span style="white-space:pre-wrap">is a known issue, the problem is that we might have tasks which will start running internally using scheduling (like OVF_UPDATE) and we can't really know how much time every task will take until it will end.</span></font></font></span></p>
<p style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="background-color:transparent;vertical-align:baseline"><font><font color="#000000" size="1" face="Arial"><span style="white-space:pre-wrap">Even if we check that there are no running tasks it will not </span></font><font color="#000000"><span style="white-space:pre-wrap">guarantee</span></font><font color="#000000"><font size="1" face="Arial"><span style="white-space:pre-wrap"> that no task will start until you deactivate the storage domain.</span></font></font></font></span></p>
<p style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="background-color:transparent;vertical-align:baseline"><font><font color="#000000"><font size="1" face="Arial"><span style="white-space:pre-wrap">I think that the best solution for it is an engine support to cancel running tasks or block tasks from running.</span></font></font></font></span></p>
</span></div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On
Thu, Dec 7, 2017 at 12:14
PM, Dafna Ron <span dir="ltr"><<a href="mailto:dron@redhat.com" target="_blank">dron@redhat.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div bgcolor="#FFFFFF">
<p>Hi, <br>
</p>
<p>We had a failure on
master basic suite for
test
007_sd_reattach.deactivate_sto<wbr>rage_domain.
<br>
</p>
<p>The failure was that
we failed to
deactivate domain due
to running tasks. <br>
</p>
<p>It does not seem to
be related to the
patch it was testing
and I think that the
test itself needs to
be modified to check
there are no running
tasks. <br>
</p>
<p>Is there perhaps a
way to query if there
are running tasks
before running the
command? can you
please take a look at
the test on OST? <br>
</p>
<p><b style="font-weight:normal" id="gmail-m_3164322619143296411m_8268433748796977447gmail-m_-4266418101369303823gmail-m_-474056254907482480m_8942236351456563473m_-5014669676915136678m_3333631383734454308m_-5329876534188665956docs-internal-guid-5859b7a1-3073-5414-18b7-2d31991889e8">
</b></p>
<p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><b style="font-weight:normal" id="gmail-m_3164322619143296411m_8268433748796977447gmail-m_-4266418101369303823gmail-m_-474056254907482480m_8942236351456563473m_-5014669676915136678m_3333631383734454308m_-5329876534188665956docs-internal-guid-5859b7a1-3073-5414-18b7-2d31991889e8"><span style="font-size:11pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;font-weight:400;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap">Link and headline of suspected patches:</span><b style="font-weight:normal" id="gmail-m_3164322619143296411m_8268433748796977447gmail-m_-4266418101369303823gmail-m_-474056254907482480m_8942236351456563473m_-5014669676915136678m_3333631383734454308m_-5329876534188665956docs-internal-guid-5859b7a1-3073-5414-18b7-2d31991889e8"><b>
Not related to
error</b></b></b></p>
<b style="font-weight:normal" id="gmail-m_3164322619143296411m_8268433748796977447gmail-m_-4266418101369303823gmail-m_-474056254907482480m_8942236351456563473m_-5014669676915136678m_3333631383734454308m_-5329876534188665956docs-internal-guid-5859b7a1-3073-5414-18b7-2d31991889e8">
</b>
<p><b style="font-weight:normal" id="gmail-m_3164322619143296411m_8268433748796977447gmail-m_-4266418101369303823gmail-m_-474056254907482480m_8942236351456563473m_-5014669676915136678m_3333631383734454308m_-5329876534188665956docs-internal-guid-5859b7a1-3073-5414-18b7-2d31991889e8">
</b></p>
<p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><b style="font-weight:normal" id="gmail-m_3164322619143296411m_8268433748796977447gmail-m_-4266418101369303823gmail-m_-474056254907482480m_8942236351456563473m_-5014669676915136678m_3333631383734454308m_-5329876534188665956docs-internal-guid-5859b7a1-3073-5414-18b7-2d31991889e8"><span style="font-size:11pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;font-weight:400;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap">Link to Job: <a class="gmail-m_3164322619143296411m_8268433748796977447gmail-m_-4266418101369303823gmail-m_-474056254907482480m_8942236351456563473m_-5014669676915136678m_3333631383734454308m_-5329876534188665956moz-txt-link-freetext" href="http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/4319/" target="_blank">http://jenkins.ovirt.org/job/o<wbr>virt-master_change-queue-teste<wbr>r/4319/</a></span></b></p>
<b style="font-weight:normal" id="gmail-m_3164322619143296411m_8268433748796977447gmail-m_-4266418101369303823gmail-m_-474056254907482480m_8942236351456563473m_-5014669676915136678m_3333631383734454308m_-5329876534188665956docs-internal-guid-5859b7a1-3073-5414-18b7-2d31991889e8">
</b><b style="font-weight:normal" id="gmail-m_3164322619143296411m_8268433748796977447gmail-m_-4266418101369303823gmail-m_-474056254907482480m_8942236351456563473m_-5014669676915136678m_3333631383734454308m_-5329876534188665956docs-internal-guid-5859b7a1-3073-5414-18b7-2d31991889e8"><br>
<p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;font-weight:400;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap">Link to all logs: <a class="gmail-m_3164322619143296411m_8268433748796977447gmail-m_-4266418101369303823gmail-m_-474056254907482480m_8942236351456563473m_-5014669676915136678m_3333631383734454308m_-5329876534188665956moz-txt-link-freetext" href="http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/4319/artifact/" target="_blank">http://jenkins.ovirt.org/job/o<wbr>virt-master_change-queue-teste<wbr>r/4319/artifact/</a></span></p>
<br>
<p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;font-weight:400;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap">(Relevant) error snippet from the log: </span></p>
<p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;font-weight:400;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap"><error></span></p>
<p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;font-weight:400;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap">
</span></p>
<p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;font-weight:400;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap"><b>2017-12-06 20:13:23,166-05 WARN [org.ovirt.engine.core.bll.sto<wbr>rage.domain.DeactivateStorageD<wbr>omainWithOvfUpdateCommand] (default task-7) [d82880e8-1d40-4a3b-a1ba-3362f<wbr>2f130a0] Validation of action 'DeactivateStorageDomainWithOv<wbr>fUpdate' fa
iled for user admin@internal-authz. Reasons: VAR__TYPE__STORAGE__DOMAIN,VAR<wbr>__ACTION__DEACTIVATE,ERROR_CAN<wbr>NOT_DEACTIVATE_DOMAIN_WITH_TAS<wbr>KS
2017-12-06 20:13:23,167-05 INFO [org.ovirt.engine.core.bll.sto<wbr>rage.domain.DeactivateStorageD<wbr>omainWithOvfUpdateCommand] (default task-7) [d82880e8-1d40-4a3b-a1ba-3362f<wbr>2f130a0] Lock freed to object 'EngineLock:{exclusiveLocks='[<wbr>ea2fd992-8a
a4-44fe-aa43-e96754a975ba=STOR<wbr>AGE]', sharedLocks='[5e0a0183-0e25-4f<wbr>43-b5b0-0cfb5510248e=POOL]'}'
2017-12-06 20:13:23,172-05 DEBUG [org.ovirt.engine.core.common.<wbr>di.interceptor.DebugLoggingInt<wbr>erceptor] (default task-7) [d82880e8-1d40-4a3b-a1ba-3362f<wbr>2f130a0] method: runAction, params: [DeactivateStorageDomainWithOv<wbr>fUpdate, DeactivateSto
rageDomainWithOvfUpdateParamet<wbr>ers:{commandId='630c28e1-41ab-<wbr>43db-9755-a2bb870dbcb3', user='null', commandType='Unknown'}], timeElapsed: 65ms
2017-12-06 20:13:23,176-05 ERROR [org.ovirt.engine.api.restapi.<wbr>resource.AbstractBackendResour<wbr>ce] (default task-7) [] Operation Failed: [Cannot deactivate Storage while there are running tasks on this Storage.
-Please wait until tasks will finish and try again.]
</b>
</span></p>
<p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;font-weight:400;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap">
</span></p>
</b><error><br class="gmail-m_3164322619143296411m_8268433748796977447gmail-m_-4266418101369303823gmail-m_-474056254907482480m_8942236351456563473m_-5014669676915136678m_3333631383734454308m_-5329876534188665956Apple-interchange-newline">
<p><br>
</p>
<p><br>
</p>
<p><br>
</p>
</div>
<br>
______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a><br>
</blockquote>
</div>
<br>
</div>
</blockquote>
<p><br>
</p>
</div>
</div>
</div>
<br>
______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a><br>
</blockquote>
</div>
<br>
</div>
</div>
<br>
______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a><br>
</blockquote>
</div>
<br>
<br clear="all">
<div><br>
</div>
</div>
</div>
<span class="gmail-m_3164322619143296411m_8268433748796977447gmail-m_-4266418101369303823gmail-m_-474056254907482480HOEnZb"><font color="#888888">-- <br>
<div class="gmail-m_3164322619143296411m_8268433748796977447gmail-m_-4266418101369303823gmail-m_-474056254907482480m_8942236351456563473gmail_signature">
<div dir="ltr">Regards,
<div>Eyal Shenitzky</div>
</div>
</div>
</font></span></div>
</blockquote>
</div>
<br>
</div>
</div>
</blockquote>
<p><br>
</p>
</div></div></div>
</blockquote></div></div></div><br></div></div>
</blockquote></div></div></div><br></div></div>
</blockquote></div><br></div></div>