<div dir="ltr">Hi,<div>I pushed two patches fixing some of the issues:</div><div><br></div><div><a href="https://gerrit.ovirt.org/#/c/85318/">https://gerrit.ovirt.org/#/c/85318/</a><br></div><div><a href="https://gerrit.ovirt.org/#/c/85316/">https://gerrit.ovirt.org/#/c/85316/</a><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Dec 12, 2017 at 2:09 AM, Nir Soffer <span dir="ltr"><<a href="mailto:nsoffer@redhat.com" target="_blank">nsoffer@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I'm trying to upgrade pylint to latest so we can enjoy latest fixes<div>like this:<br><div><a href="https://github.com/PyCQA/pylint/issues/1736" target="_blank">https://github.com/PyCQA/<wbr>pylint/issues/1736</a><br></div><div><br></div><div>Now we have some new errors, please check.</div><div><br></div><div><pre class="m_-7078410385756542366inbox-inbox-console-output" style="box-sizing:border-box;white-space:pre-wrap;word-wrap:break-word;margin-top:0px;margin-bottom:0px;color:rgb(51,51,51);font-size:14px"><span style="box-sizing:border-box;color:rgb(255,255,255)"><span style="box-sizing:border-box;background-color:rgb(205,205,0)">************* Module vdsm.clientIF</span></span>
<span class="m_-7078410385756542366inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">00:06:53.857</b> </span><b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">E</span></b>:588,16: <b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">Possible unbalanced tuple unpacking with sequence: left side has 2 label(s), right side has 0 value(s)</span></b> (<b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">unbalanced-tuple-unpacking</span></b>)</pre><pre class="m_-7078410385756542366inbox-inbox-console-output" style="box-sizing:border-box;white-space:pre-wrap;word-wrap:break-word;margin-top:0px;margin-bottom:0px;color:rgb(51,51,51);font-size:14px"><br></pre><pre class="m_-7078410385756542366inbox-inbox-console-output" style="box-sizing:border-box;word-wrap:break-word;margin-top:0px;margin-bottom:0px"><font color="#333333"><span style="font-size:14px;white-space:pre-wrap">587 if eventid == libvirt.VIR_DOMAIN_EVENT_ID_<wbr>LIFECYCLE:
588 event, detail = args[:-1]
589 v.onLibvirtLifecycleEvent(<wbr>event, detail, None)</span></font><span style="color:rgb(51,51,51);font-size:14px;white-space:pre-wrap">
</span></pre><div><br></div><div>Code is indeed incorrect, should be:</div><div><br></div><div> <span style="font-size:14px;white-space:pre-wrap;color:rgb(51,51,51)">event, detail = args[:2] </span></div><pre class="m_-7078410385756542366inbox-inbox-console-output" style="box-sizing:border-box;white-space:pre-wrap;word-wrap:break-word;margin-top:0px;margin-bottom:0px;color:rgb(51,51,51);font-size:14px"><span class="m_-7078410385756542366inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box"><br></b></span></pre><pre class="m_-7078410385756542366inbox-inbox-console-output" style="box-sizing:border-box;white-space:pre-wrap;word-wrap:break-word;margin-top:0px;margin-bottom:0px;color:rgb(51,51,51);font-size:14px"><span class="m_-7078410385756542366inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">00:06:53.859</b> </span><b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">E</span></b>:593,16: <b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">Possible unbalanced tuple unpacking with sequence: left side has 1 label(s), right side has 0 value(s)</span></b> (<b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">unbalanced-tuple-unpacking</span></b>)
<span class="m_-7078410385756542366inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">00:06:53.861</b> </span><b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">E</span></b>:596,16: <b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">Possible unbalanced tuple unpacking with sequence: left side has 4 label(s), right side has 0 value(s)</span></b> (<b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">unbalanced-tuple-unpacking</span></b>)
<span class="m_-7078410385756542366inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">00:06:53.863</b> </span><b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">E</span></b>:599,16: <b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">Possible unbalanced tuple unpacking with sequence: left side has 5 label(s), right side has 0 value(s)</span></b> (<b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">unbalanced-tuple-unpacking</span></b>)
<span class="m_-7078410385756542366inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">00:06:53.867</b> </span><b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">E</span></b>:610,16: <b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">Possible unbalanced tuple unpacking with sequence: left side has 1 label(s), right side has 0 value(s)</span></b> (<b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">unbalanced-tuple-unpacking</span></b>)
<span class="m_-7078410385756542366inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">00:06:53.869</b> </span><b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">E</span></b>:615,16: <b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">Possible unbalanced tuple unpacking with sequence: left side has 1 label(s), right side has 0 value(s)</span></b> (<b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">unbalanced-tuple-unpacking</span></b>)
<span class="m_-7078410385756542366inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">00:06:53.872</b> </span><b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">E</span></b>:618,16: <b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">Possible unbalanced tuple unpacking with sequence: left side has 4 label(s), right side has 0 value(s)</span></b> (<b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">unbalanced-tuple-unpacking</span></b>)
<span class="m_-7078410385756542366inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">00:06:53.873</b> </span><span style="box-sizing:border-box;background-color:currentcolor"><span style="box-sizing:border-box;color:rgb(255,255,255)"></span></span><span style="box-sizing:border-box;color:rgb(255,255,255)"><span style="box-sizing:border-box;background-color:rgb(205,205,0)">************* Module vdsm.v2v</span></span>
<span class="m_-7078410385756542366inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">00:06:53.874</b> </span><b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">E</span></b>:1368,27: <b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">Instance of 'closing' has no 'read' member</span></b> (<b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">no-member</span></b>)
<span class="m_-7078410385756542366inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">00:06:53.876</b> </span><span style="box-sizing:border-box;background-color:currentcolor"><span style="box-sizing:border-box;color:rgb(255,255,255)"></span></span><span style="box-sizing:border-box;color:rgb(255,255,255)"><span style="box-sizing:border-box;background-color:rgb(205,205,0)">************* Module vdsm.tool.configurator</span></span>
<span class="m_-7078410385756542366inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">00:06:53.878</b> </span><b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">E</span></b>:118,12: <b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">No value for argument 'action' in function call</span></b> (<b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">no-value-for-parameter</span></b>)
<span class="m_-7078410385756542366inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">00:06:53.880</b> </span><b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">E</span></b>:158,12: <b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">No value for argument 'action' in function call</span></b> (<b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">no-value-for-parameter</span></b>)
<span class="m_-7078410385756542366inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">00:06:53.881</b> </span><b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">E</span></b>:193,12: <b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">No value for argument 'action' in function call</span></b> (<b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">no-value-for-parameter</span></b>)
<span class="m_-7078410385756542366inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">00:06:53.883</b> </span><b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">E</span></b>:215,12: <b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">No value for argument 'action' in function call</span></b> (<b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">no-value-for-parameter</span></b>)
<span class="m_-7078410385756542366inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">00:06:53.885</b> </span><span style="box-sizing:border-box;background-color:currentcolor"><span style="box-sizing:border-box;color:rgb(255,255,255)"></span></span><span style="box-sizing:border-box;color:rgb(255,255,255)"><span style="box-sizing:border-box;background-color:rgb(205,205,0)">************* Module vdsm.virt.vm_migrate_hook</span></span>
<span class="m_-7078410385756542366inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">00:06:53.886</b> </span><b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">E</span></b>:199, 4: <b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">No value for argument 'domain' in function call</span></b> (<b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">no-value-for-parameter</span></b>)
<span class="m_-7078410385756542366inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">00:06:53.888</b> </span><b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">E</span></b>:199, 4: <b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">No value for argument 'event' in function call</span></b> (<b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">no-value-for-parameter</span></b>)
<span class="m_-7078410385756542366inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">00:06:53.890</b> </span><b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">E</span></b>:199, 4: <b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">No value for argument 'phase' in function call</span></b> (<b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">no-value-for-parameter</span></b>)
<span class="m_-7078410385756542366inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">00:06:53.892</b> </span><span style="box-sizing:border-box;background-color:currentcolor"><span style="box-sizing:border-box;color:rgb(255,255,255)"></span></span><span style="box-sizing:border-box;color:rgb(255,255,255)"><span style="box-sizing:border-box;background-color:rgb(205,205,0)">************* Module vdsm.network.netlink.monitor</span></span>
<span class="m_-7078410385756542366inbox-inbox-timestamp" style="box-sizing:border-box"><b style="box-sizing:border-box">00:06:53.893</b> </span><b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">E</span></b>:172,58: <b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">Instance of 'closing' has no 'poll' member</span></b> (<b style="box-sizing:border-box"><span style="box-sizing:border-box;color:rgb(205,0,0)">no-member</span></b>)</pre></div></div></div>
<br>______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/devel</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase"><span>IRIT</span> <span>GOIHMAN</span></p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase"><span>SOFTWARE ENGINEER</span></p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase"><span>EMEA VIRTUALIZATION R&D</span></p><p style="font-family:overpass,sans-serif;margin:0px;font-size:10px;color:rgb(153,153,153)"><a href="https://www.redhat.com/" style="color:rgb(0,136,206);margin:0px" target="_blank">Red Hat <span>EMEA</span></a></p><p style="font-family:overpass,sans-serif;margin:0px 0px 6px;font-size:10px;color:rgb(153,153,153)"></p><table border="0" style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium"><tbody><tr><td width="100px"><a href="https://red.ht/sig" target="_blank"><img src="https://www.redhat.com/files/brand/email/sig-redhat.png" width="90" height="auto"></a></td><td style="font-size:10px"><div><a href="https://redhat.com/trusted" style="color:rgb(204,0,0);font-weight:bold" target="_blank">TRIED. TESTED. TRUSTED.</a></div></td></tr></tbody></table><div style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px"><div style="color:rgb(153,153,153)"><a href="https://twitter.com/redhatnews" title="twitter" style="background:url("https://www.redhat.com/files/brand/email/sm-twitter.png") 0px 50%/16px no-repeat transparent;height:20px;color:rgb(119,119,119);display:inline-block;line-height:20px;padding-left:16px" target="_blank">@redhatnews</a> <a href="https://www.linkedin.com/company/red-hat" title="LinkedIn" style="background:url("https://www.redhat.com/files/brand/email/sm-linkedin.png") 0px 50%/16px no-repeat transparent;height:20px;color:rgb(119,119,119);display:inline-block;line-height:20px;padding-left:16px" target="_blank">Red Hat</a> <a href="https://www.facebook.com/RedHatInc" title="Facebook" style="background:url("https://www.redhat.com/files/brand/email/sm-facebook.png") 0px 50%/16px no-repeat transparent;height:20px;color:rgb(119,119,119);display:inline-block;line-height:20px;padding-left:16px" target="_blank">Red Hat</a></div></div><div style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px"></div></div></div></div></div>
</div>