<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On 25 December 2017 at 16:59, Eyal Edri <span dir="ltr"><<a href="mailto:eedri@redhat.com" target="_blank">eedri@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span>On Mon, Dec 25, 2017 at 2:20 PM, Barak Korren <span dir="ltr"><<a href="mailto:bkorren@redhat.com" target="_blank">bkorren@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="gmail-m_3413403587615219469m_6138213104989878517gmail-">On 25 December 2017 at 10:50, Eyal Edri <span dir="ltr"><<a href="mailto:eedri@redhat.com" target="_blank">eedri@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">I'm testing a revert of the patch [1], but it looks like it is very related and suspicion is around ansible not configured firewalld and thus causing the failure.<div>Gal has been debugging the same issue downstream yesterday. </div><div><br></div><div><br></div><div>[1] <a href="https://gerrit.ovirt.org/#/c/85723/" target="_blank">https://gerrit.ovirt.org/#<wbr>/c/85723/</a></div></div><div class="gmail_extra"><br><br></div></blockquote><div><br></div></span><div>Revet patch failed to pass CQ:<br><a href="http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/4518/" target="_blank">http://jenkins.ovirt.org/job/o<wbr>virt-master_change-queue-teste<wbr>r/4518/</a><br></div><div><br></div><div>I'm rerunning just in case it passes a 2nd time:<br><a href="http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/4520/" target="_blank">http://jenkins.ovirt.org/job/o<wbr>virt-master_change-queue-teste<wbr>r/4520/</a> <br></div></div><br></div><div class="gmail_extra">Maybe we need to revert the firewalld patch too:<br><a href="https://gerrit.ovirt.org/c/85326" target="_blank">https://gerrit.ovirt.org/c/853<wbr>26</a> (<span class="gmail-m_3413403587615219469m_6138213104989878517gmail-m_-4339438477219944250gmail-header-title gmail-m_3413403587615219469m_6138213104989878517gmail-m_-4339438477219944250gmail-style-scope gmail-m_3413403587615219469m_6138213104989878517gmail-m_-4339438477219944250gmail-gr-change-view">engine: Let backend choose default firewall type)</span></div></div></blockquote><div><br></div><div><br></div></span><div>OK, Thanks for Gal for debugging this further, it seems that a different patch was causing the failure:</div><div><a href="https://gerrit.ovirt.org/#/c/85611/" target="_blank">https://gerrit.ovirt.org/#/c/8<wbr>5611/</a> - <span style="color:rgb(53,53,53);font-family:monospace;white-space:pre-wrap">core: ansible: Don't print errors when files not found</span><br></div><div><span style="color:rgb(53,53,53);font-family:monospace;white-space:pre-wrap"><br></span></div><div><span style="color:rgb(53,53,53);font-family:monospace;white-space:pre-wrap">I've tested a revert patch [1]( rebased on master ) and it passed here [2].</span></div><div><span style="color:rgb(53,53,53);font-family:monospace;white-space:pre-wrap"><br></span></div><div><span style="color:rgb(53,53,53);font-family:monospace;white-space:pre-wrap">Details on why it caused the failure will be added to the revert patch commit msg.</span></div></div></div></div></blockquote><div><br><br></div><div>This had now finally passed OST/CQ:<br><a href="http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/4522/">http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/4522/</a> <br></div></div><br><br clear="all"><br>-- <br><div class="gmail-m_3413403587615219469gmail_signature">Barak Korren<br>RHV DevOps team , RHCE, RHCi<br>Red Hat EMEA<br><a href="http://redhat.com" target="_blank">redhat.com</a> | TRIED. TESTED. TRUSTED. | <a href="http://redhat.com/trusted" target="_blank">redhat.com/trusted</a></div>
</div></div>