<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On 12 Jan 2018, at 17:32, Yaniv Kaul <<a href="mailto:ykaul@redhat.com" class="">ykaul@redhat.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><br class="Apple-interchange-newline"><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div class="gmail_quote" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;">On Fri, Jan 12, 2018 at 1:05 PM, Michal Skrivanek<span class="Apple-converted-space"> </span><span dir="ltr" class=""><<a href="mailto:michal.skrivanek@redhat.com" target="_blank" class="">michal.skrivanek@redhat.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br class=""><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div style="word-wrap: break-word; line-break: after-white-space;" class=""><br class=""><div class=""><span class=""><br class=""><blockquote type="cite" class=""><div class="">On 12 Jan 2018, at 08:32, Tomas Jelinek <<a href="mailto:tjelinek@redhat.com" target="_blank" class="">tjelinek@redhat.com</a>> wrote:</div><br class="m_5286394179726035691Apple-interchange-newline"><div class=""><div dir="ltr" class=""><br class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On Fri, Jan 12, 2018 at 8:18 AM, Yaniv Kaul<span class="Apple-converted-space"> </span><span dir="ltr" class=""><<a href="mailto:ykaul@redhat.com" target="_blank" class="">ykaul@redhat.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br class=""><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div dir="ltr" class=""><br class=""><div class="gmail_extra"><br class=""><div class="gmail_quote"><span class="">On Fri, Jan 12, 2018 at 9:06 AM, Yaniv Kaul<span class="Apple-converted-space"> </span><span dir="ltr" class=""><<a href="mailto:ykaul@redhat.com" target="_blank" class="">ykaul@redhat.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br class=""><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div dir="ltr" class="">See[1] - do we need to update Lago / Lago OST plugin?</div></blockquote><div class=""><br class=""></div></span><div class="">Something like <a href="https://github.com/lago-project/lago-ost-plugin/pull/31" target="_blank" class="">https://github.com/lago-p<wbr class="">roject/lago-ost-plugin/pull/31</a><span class="Apple-converted-space"> </span>perhaps (not tested, don't have the HW).</div></div></div></div></blockquote><div class=""><br class=""></div><div class="">yes, seems like that should do the trick.<br class=""></div></div></div></div></div></blockquote><div class=""><br class=""></div></span>sure, though, that list is also difficult to maintain</div><div class="">e.g. IvyBridge is not an oVirt supported model, there’s no “Skylake” model</div><div class=""><br class=""></div><div class="">Nadav, what’s the exact purpose of that list, and can it be eliminated somehow?</div></div></blockquote><div class=""><br class=""></div><div class="">It's to match, as possible, between the host CPU (which is passed to L1) so it'll match oVirt’s.</div></div></div></blockquote><div><br class=""></div><div>getting it from "virsh capabilities" on the host would match it a bit better. It would be enough to just make the L1 host report (via fake caps hook if needed) the same model_X in getVdsCapabilities as the L0 </div><br class=""><blockquote type="cite" class=""><div class=""><div class="gmail_quote" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div class="">It's not that difficult to maintain. We add new CPUs once-twice a year…?</div></div></div></blockquote><div><br class=""></div>yes, not often</div><div><br class=""><blockquote type="cite" class=""><div class=""><div class="gmail_quote" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div class="">Y.</div><div class=""> </div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div style="word-wrap: break-word; line-break: after-white-space;" class=""><div class=""><br class=""></div><div class="">Thanks,</div><div class="">michal</div><div class=""><div class="h5"><div class=""><br class=""></div><div class=""><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><div class=""> </div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><span class="m_5286394179726035691HOEnZb"><font color="#888888" class=""><div class="">Y.</div></font></span><span class=""><div class=""> </div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><div dir="ltr" class=""><div class=""><h3 style="box-sizing: border-box; color: rgb(51, 51, 51); font-family: Helvetica, Arial, sans-serif;" class="">Error Message</h3><pre style="box-sizing: border-box; white-space: pre-wrap; word-wrap: break-word; margin-top: 0px; margin-bottom: 0px; color: rgb(51, 51, 51); font-size: 13px;" class="">Unsupported CPU model: Haswell-noTSX-IBRS. Supported models: IvyBridge,Westmere,Skylake,Pen<wbr class="">ryn,Haswell,Broadwell,Nehalem,<wbr class="">Skylake-Client,Broadwell-noTSX<wbr class="">,Conroe,SandyBridge,Haswell-<wbr class="">noTSX</pre><h3 style="box-sizing: border-box; color: rgb(51, 51, 51); font-family: Helvetica, Arial, sans-serif;" class="">Stacktrace</h3><pre style="box-sizing: border-box; white-space: pre-wrap; word-wrap: break-word; margin-top: 0px; margin-bottom: 0px; color: rgb(51, 51, 51); font-size: 13px;" class="">Traceback (most recent call last):
File "/usr/lib64/python2.7/unittest<wbr class="">/case.py", line 369, in run
testMethod()
File "/usr/lib/python2.7/site-packa<wbr class="">ges/nose/case.py", line 197, in runTest
self.test(*self.arg)
File "/usr/lib/python2.7/site-packa<wbr class="">ges/ovirtlago/testlib.py", line 129, in wrapped_test
test()
File "/usr/lib/python2.7/site-packa<wbr class="">ges/ovirtlago/testlib.py", line 59, in wrapper
return func(get_test_prefix(), *args, **kwargs)
File "/home/jenkins/workspace/ovirt<wbr class="">-system-tests_master_check-pat<wbr class="">ch-el7-x86_64/ovirt-system-tes<wbr class="">ts/basic-suite-master/test-sce<wbr class="">narios/002_bootstrap.py", line 277, in add_cluster
add_cluster_4(prefix)
File "/home/jenkins/workspace/ovirt<wbr class="">-system-tests_master_check-pat<wbr class="">ch-el7-x86_64/ovirt-system-tes<wbr class="">ts/basic-suite-master/test-sce<wbr class="">narios/002_bootstrap.py", line 305, in add_cluster_4
cpu_family = prefix.virt_env.get_ovirt_cpu_<wbr class="">family()
File "/usr/lib/python2.7/site-packa<wbr class="">ges/ovirtlago/virt.py", line 151, in get_ovirt_cpu_family
','.join(cpu_map[host.cpu_vend<wbr class="">or].iterkeys())
RuntimeError: Unsupported CPU model: Haswell-noTSX-IBRS. Supported models: IvyBridge,Westmere,Skylake,Pen<wbr class="">ryn,Haswell,Broadwell,Nehalem,<wbr class="">Skylake-Client,Broadwell-noTSX<wbr class="">,Conroe,SandyBridge,Haswell-<wbr class="">noTSX</pre><pre style="box-sizing: border-box; white-space: pre-wrap; word-wrap: break-word; margin-top: 0px; margin-bottom: 0px; color: rgb(51, 51, 51); font-size: 13px;" class=""><br class=""></pre><pre style="box-sizing: border-box; white-space: pre-wrap; word-wrap: break-word; margin-top: 0px; margin-bottom: 0px; color: rgb(51, 51, 51); font-size: 13px;" class=""><br class=""></pre></div><div class=""><pre style="box-sizing: border-box; white-space: pre-wrap; word-wrap: break-word; margin-top: 0px; margin-bottom: 0px; color: rgb(51, 51, 51); font-size: 13px;" class="">Y.</pre><pre style="box-sizing: border-box; white-space: pre-wrap; word-wrap: break-word; margin-top: 0px; margin-bottom: 0px; color: rgb(51, 51, 51); font-size: 13px;" class="">[1] <a href="http://jenkins.ovirt.org/job/ovirt-system-tests_master_check-patch-el7-x86_64/3498/testReport/junit/(root)/002_bootstrap/add_cluster/" target="_blank" class="">http://jenkins.ovirt.org/job/o<wbr class="">virt-system-tests_master_check<wbr class="">-patch-el7-x86_64/3498/testRep<wbr class="">ort/junit/(root)/002_bootstrap<wbr class="">/add_cluster/</a></pre></div></div></blockquote></span></div><br class=""></div></div><br class="">______________________________<wbr class="">_________________<br class="">Devel mailing list<br class=""><a href="mailto:Devel@ovirt.org" target="_blank" class="">Devel@ovirt.org</a><br class=""><a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank" class="">http://lists.ovirt.org/mailman<wbr class="">/listinfo/devel</a><br class=""></blockquote></div><br class=""></div></div>______________________________<wbr class="">_________________<br class="">Devel mailing list<br class=""><a href="mailto:Devel@ovirt.org" target="_blank" class="">Devel@ovirt.org</a><br class=""><a href="http://lists.ovirt.org/mailman/listinfo/devel" target="_blank" class="">http://lists.ovirt.org/<wbr class="">mailman/listinfo/devel</a></div></blockquote></div></div></div></div></blockquote></div></div></blockquote></div><br class=""></body></html>