<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jan 12, 2018 at 7:07 PM, Yaniv Kaul <span dir="ltr"><<a href="mailto:ykaul@redhat.com" target="_blank">ykaul@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="gmail-">On Fri, Jan 12, 2018 at 6:49 PM, Michal Skrivanek <span dir="ltr"><<a href="mailto:michal.skrivanek@redhat.com" target="_blank">michal.skrivanek@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word"><br><div><span><br><blockquote type="cite"><div>On 12 Jan 2018, at 17:32, Yaniv Kaul <<a href="mailto:ykaul@redhat.com" target="_blank">ykaul@redhat.com</a>> wrote:</div><br class="gmail-m_-908757012461244851m_3488975926329217664Apple-interchange-newline"><div><br class="gmail-m_-908757012461244851m_3488975926329217664Apple-interchange-newline"><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><div class="gmail_quote" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">On Fri, Jan 12, 2018 at 1:05 PM, Michal Skrivanek<span class="gmail-m_-908757012461244851m_3488975926329217664Apple-converted-space"> </span><span dir="ltr"><<a href="mailto:michal.skrivanek@redhat.com" target="_blank">michal.skrivanek@re<wbr>dhat.com</a>></span><span class="gmail-m_-908757012461244851m_3488975926329217664Apple-converted-space"> </span>wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word"><br><div><span><br><blockquote type="cite"><div>On 12 Jan 2018, at 08:32, Tomas Jelinek <<a href="mailto:tjelinek@redhat.com" target="_blank">tjelinek@redhat.com</a>> wrote:</div><br class="gmail-m_-908757012461244851m_3488975926329217664m_5286394179726035691Apple-interchange-newline"><div><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jan 12, 2018 at 8:18 AM, Yaniv Kaul<span class="gmail-m_-908757012461244851m_3488975926329217664Apple-converted-space"> </span><span dir="ltr"><<a href="mailto:ykaul@redhat.com" target="_blank">ykaul@redhat.com</a>></span><span class="gmail-m_-908757012461244851m_3488975926329217664Apple-converted-space"> </span>wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span>On Fri, Jan 12, 2018 at 9:06 AM, Yaniv Kaul<span class="gmail-m_-908757012461244851m_3488975926329217664Apple-converted-space"> </span><span dir="ltr"><<a href="mailto:ykaul@redhat.com" target="_blank">ykaul@redhat.com</a>></span><span class="gmail-m_-908757012461244851m_3488975926329217664Apple-converted-space"> </span>wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">See[1] - do we need to update Lago / Lago OST plugin?</div></blockquote><div><br></div></span><div>Something like <a href="https://github.com/lago-project/lago-ost-plugin/pull/31" target="_blank">https://github.com/lago-p<wbr>roject/lago-ost-plugin/pull/31</a><span class="gmail-m_-908757012461244851m_3488975926329217664Apple-converted-space"><wbr> </span>perhaps (not tested, don't have the HW).</div></div></div></div></blockquote><div><br></div><div>yes, seems like that should do the trick.<br></div></div></div></div></div></blockquote><div><br></div></span>sure, though, that list is also difficult to maintain</div><div>e.g. IvyBridge is not an oVirt supported model, there’s no “Skylake” model</div><div><br></div><div>Nadav, what’s the exact purpose of that list, and can it be eliminated somehow?</div></div></blockquote><div><br></div><div>It's to match, as possible, between the host CPU (which is passed to L1) so it'll match oVirt’s.</div></div></div></blockquote><div><br></div></span><div>getting it from "virsh capabilities" on the host would match it a bit better. It would be enough to just make the L1 host report (via fake caps hook if needed) the same model_X in getVdsCapabilities as the L0 </div></div></div></blockquote></span></div></div></div></blockquote><div><br></div><div>1. Can you please explain how it can be achieved? </div><div>2. Will it eliminate the need to translate between the cpu model and the cpu family?</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class="gmail-"><div><br></div></span><div>That used to be my initial implementation. I don't recall why it was changed.</div><span class="gmail-HOEnZb"><font color="#888888"><div>Y.</div></font></span><div><div class="gmail-h5"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word"><div><br><blockquote type="cite"><div><div class="gmail_quote" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><div>It's not that difficult to maintain. We add new CPUs once-twice a year…?</div></div></div></blockquote><div><br></div>yes, not often</div><div><div class="gmail-m_-908757012461244851h5"><div><br><blockquote type="cite"><div><div class="gmail_quote" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><div>Y.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word"><div><br></div><div>Thanks,</div><div>michal</div><div><div class="gmail-m_-908757012461244851m_3488975926329217664h5"><div><br></div><div><br><blockquote type="cite"><div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class="gmail-m_-908757012461244851m_3488975926329217664m_5286394179726035691HOEnZb"><font color="#888888"><div>Y.</div></font></span><span><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><h3 style="box-sizing:border-box;color:rgb(51,51,51);font-family:Helvetica,Arial,sans-serif">Error Message</h3><pre style="box-sizing:border-box;white-space:pre-wrap;word-wrap:break-word;margin-top:0px;margin-bottom:0px;color:rgb(51,51,51);font-size:13px">Unsupported CPU model: Haswell-noTSX-IBRS. Supported models: IvyBridge,Westmere,Skylake,Pen<wbr>ryn,Haswell,Broadwell,Nehalem,<wbr>Skylake-Client,Broadwell-noTSX<wbr>,Conroe,SandyBridge,Haswell-no<wbr>TSX</pre><h3 style="box-sizing:border-box;color:rgb(51,51,51);font-family:Helvetica,Arial,sans-serif">Stacktrace</h3><pre style="box-sizing:border-box;white-space:pre-wrap;word-wrap:break-word;margin-top:0px;margin-bottom:0px;color:rgb(51,51,51);font-size:13px">Traceback (most recent call last):
File "/usr/lib64/python2.7/unittest<wbr>/case.py", line 369, in run
testMethod()
File "/usr/lib/python2.7/site-packa<wbr>ges/nose/case.py", line 197, in runTest
self.test(*self.arg)
File "/usr/lib/python2.7/site-packa<wbr>ges/ovirtlago/testlib.py", line 129, in wrapped_test
test()
File "/usr/lib/python2.7/site-packa<wbr>ges/ovirtlago/testlib.py", line 59, in wrapper
return func(get_test_prefix(), *args, **kwargs)
File "/home/jenkins/workspace/ovirt<wbr>-system-tests_master_check-pat<wbr>ch-el7-x86_64/ovirt-system-tes<wbr>ts/basic-suite-master/test-sce<wbr>narios/002_bootstrap.py", line 277, in add_cluster
add_cluster_4(prefix)
File "/home/jenkins/workspace/ovirt<wbr>-system-tests_master_check-pat<wbr>ch-el7-x86_64/ovirt-system-tes<wbr>ts/basic-suite-master/test-sce<wbr>narios/002_bootstrap.py", line 305, in add_cluster_4
cpu_family = prefix.virt_env.get_ovirt_cpu_<wbr>family()
File "/usr/lib/python2.7/site-packa<wbr>ges/ovirtlago/virt.py", line 151, in get_ovirt_cpu_family
','.join(cpu_map[host.cpu_vend<wbr>or].iterkeys())
RuntimeError: Unsupported CPU model: Haswell-noTSX-IBRS. Supported models: IvyBridge,Westmere,Skylake,Pen<wbr>ryn,Haswell,Broadwell,Nehalem,<wbr>Skylake-Client,Broadwell-noTSX<wbr>,Conroe,SandyBridge,Haswell-no<wbr>TSX</pre><pre style="box-sizing:border-box;white-space:pre-wrap;word-wrap:break-word;margin-top:0px;margin-bottom:0px;color:rgb(51,51,51);font-size:13px"><br></pre><pre style="box-sizing:border-box;white-space:pre-wrap;word-wrap:break-word;margin-top:0px;margin-bottom:0px;color:rgb(51,51,51);font-size:13px"><br></pre></div><div><pre style="box-sizing:border-box;white-space:pre-wrap;word-wrap:break-word;margin-top:0px;margin-bottom:0px;color:rgb(51,51,51);font-size:13px">Y.</pre><pre style="box-sizing:border-box;white-space:pre-wrap;word-wrap:break-word;margin-top:0px;margin-bottom:0px;color:rgb(51,51,51);font-size:13px">[1] <a href="http://jenkins.ovirt.org/job/ovirt-system-tests_master_check-patch-el7-x86_64/3498/testReport/junit/(root)/002_bootstrap/add_cluster/" target="_blank">http://jenkins.ovirt.org/job/o<wbr>virt-system-tests_master_check<wbr>-patch-el7-x86_64/3498/testRep<wbr>ort/junit/(root)/002_bootstrap<wbr>/add_cluster/</a></pre></div></div></blockquote></span></div><br></div></div><br>______________________________<wbr>_________________<br>Devel mailing list<br><a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br><a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a><br></blockquote></div><br></div></div>______________________________<wbr>_________________<br>Devel mailing list<br><a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br><a href="http://lists.ovirt.org/mailman/listinfo/devel" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a></div></blockquote></div></div></div></div></blockquote></div></div></blockquote></div><br></div></div></div></blockquote></div></div></div><br></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><font face="overpass, sans-serif" color="#000000" size="2"><span style="text-transform:uppercase"><b>GAL bEN HAIM</b></span></font><div><span style="color:rgb(0,0,0);font-family:overpass,sans-serif;text-transform:uppercase"><font size="2">RHV DEVOPS</font></span><br></div></div></div>
</div></div>