<div dir="ltr"><div><div><div>Dear Yedidyah,<br><br></div>Thank you for your response. I have attached the two dump files. The first is the original error for isort, dump.txt. The second dump_isort.txt is after installing python2_isort.<br><br></div>With Best Regards.<br><br></div>Steven Rosenberg.<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Feb 26, 2018 at 3:10 PM, Yedidyah Bar David <span dir="ltr"><<a href="mailto:didi@redhat.com" target="_blank">didi@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<div><div class="h5"><br>
On Mon, Feb 26, 2018 at 2:39 PM, Steven Rosenberg <<a href="mailto:srosenbe@redhat.com">srosenbe@redhat.com</a>> wrote:<br>
> Dear Martin,<br>
><br>
> I should add I am running RHEL 7.4 (Maipo).<br>
><br>
> With Best Regards.<br>
><br>
> Steven Rosenberg.<br>
><br>
> On Mon, Feb 26, 2018 at 2:24 PM, Martin Perina <<a href="mailto:mperina@redhat.com">mperina@redhat.com</a>> wrote:<br>
>><br>
>> Didi/Sandro, any ideas about it? AFAIK on CentOS/RHEL 7 everything works<br>
>> as expected ...<br>
>><br>
>><br>
>> On Mon, Feb 26, 2018 at 11:58 AM, Steven Rosenberg <<a href="mailto:srosenbe@redhat.com">srosenbe@redhat.com</a>><br>
>> wrote:<br>
>>><br>
>>> Dear Martin Perina,<br>
>>><br>
>>> We found some issues with the oVirt Engine master branch when updating<br>
>>> the version via git pull.<br>
>>><br>
>>> We then performed the make command:<br>
>>><br>
>>> make clean install-dev PREFIX=~/ovirt_engine_master<br>
>>> DEV_BUILD_SCL_POSTGRESQL=1<br>
>>><br>
>>> It seems a new dependency was added for isort, so the make fails with the<br>
>>> following error:<br>
>>><br>
>>><br>
>>> ------------------------------<wbr>------------------------------<wbr>------------------------------<wbr>--------------------------<br>
>>><br>
>>><br>
>>> packaging/setup/plugins/ovirt-<wbr>engine-rename/ovirt-engine/<wbr>database.py:313:21:<br>
>>> E126 continuation line over-indented for hanging indent<br>
>>><br>
>>> packaging/setup/plugins/ovirt-<wbr>engine-rename/ovirt-engine/<wbr>database.py:314:21:<br>
>>> E126 continuation line over-indented for hanging indent<br>
>>><br>
>>> packaging/setup/plugins/ovirt-<wbr>engine-common/base/core/<wbr>duplicated_constants_check.py:<wbr>109:17:<br>
>>> E124 closing bracket does not match visual indentation<br>
>>> + ret=1<br>
>>> + which isort<br>
>>> + echo 'WARNING: tool '\''isort'\'' is missing'<br>
>>> WARNING: tool 'isort' is missing<br>
<br>
</div></div>This is just a warning<br>
<br>
>>> + exit 1<br>
<br>
Most likely the error causing it to exit 1 happened earlier, please check/share<br>
more of the output.<br>
<span class=""><br>
>>> make[1]: *** [validations] Error 1<br>
>>> make[1]: Leaving directory `/home/srosenbe/Documents/git/<wbr>ovirt-engine'<br>
>>> make: *** [all-dev] Error 2<br>
>>><br>
>>><br>
>>> ------------------------------<wbr>------------------------------<wbr>------------------------------<wbr>--------------------------<br>
>>><br>
>>> To attempt to address this issue, we guessed and installed python2-isort<br>
>>> through yum, though the readme states it is optional.<br>
>>><br>
>>> Though the process continued, it then failed in the python module:<br>
>>><br>
>>><br>
>>> /home/srosenbe/Documents/git/<wbr>ovirt-engine/packaging/<wbr>pythonlib/ovirt_engine/<wbr>service.py<br>
>>><br>
>>> That error is here:<br>
>>><br>
>>><br>
>>> ------------------------------<wbr>------------------------------<wbr>------------------------------<wbr>------------------------------<wbr>---<br>
>>><br>
>>><br>
>>> ---<br>
>>> /home/srosenbe/Documents/git/<wbr>ovirt-engine/packaging/<wbr>pythonlib/ovirt_engine/<wbr>service.py:before<br>
>>> 2018-02-12 12:17:26<br>
>>> +++<br>
>>> /home/srosenbe/Documents/git/<wbr>ovirt-engine/packaging/<wbr>pythonlib/ovirt_engine/<wbr>service.py:after<br>
>>> 2018-02-26 12:07:11.233915<br>
>>> @@ -31,6 +31,7 @@<br>
>>> import time<br>
>>><br>
>>> import daemon<br>
>>> +<br>
>>><br>
>>> from dateutil import tz<br>
>>><br>
<br>
</span>This is an output of 'isort --diff', and not the actual error.<br>
<br>
(isort --check, which is what we run to test the code, does not fail if<br>
the diff it would have suggested consists of only difference in the number<br>
of empty lines. It would still be nice to patch service.py to have another<br>
empty line, but not needed).<br>
<br>
>>> + exit 1<br>
<br>
Same. Error was most likely earlier.<br>
<br>
Best regards,<br>
<div class="HOEnZb"><div class="h5"><br>
>>> make[1]: *** [validations] Error 1<br>
>>> make[1]: Leaving directory `/home/srosenbe/Documents/git/<wbr>ovirt-engine'<br>
>>> make: *** [all-dev] Error 2<br>
>>><br>
>>><br>
>>> ------------------------------<wbr>------------------------------<wbr>------------------------------<wbr>------------------------------<wbr>---<br>
>>><br>
>>> Please advise if you have a quick fix or when this issue will be<br>
>>> addressed.<br>
>>><br>
>>> Thank you for your time and consideration.<br>
>>><br>
>>> With Best Regards.<br>
>>><br>
>>> Steven Rosenberg.<br>
>>><br>
>><br>
>><br>
>><br>
>> --<br>
>> Martin Perina<br>
>> Associate Manager, Software Engineering<br>
>> Red Hat Czech s.r.o.<br>
><br>
><br>
<br>
<br>
<br>
</div></div><span class="HOEnZb"><font color="#888888">--<br>
Didi<br>
</font></span></blockquote></div><br></div>