<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Strange, I've just tried to build latest master using python2-isort-4.2.5-8.el7 on latest RHEL 7.4 and it finished successfully without any errors ...<br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Feb 26, 2018 at 2:31 PM, Yedidyah Bar David <span dir="ltr"><<a href="mailto:didi@redhat.com" target="_blank">didi@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Mon, Feb 26, 2018 at 3:19 PM, Steven Rosenberg <<a href="mailto:srosenbe@redhat.com">srosenbe@redhat.com</a>> wrote:<br>
> Dear Yedidyah,<br>
><br>
> Thank you for your response. I have attached the two dump files. The first<br>
> is the original error for isort, dump.txt. The second dump_isort.txt is<br>
> after installing python2_isort.<br>
<br>
This is the error:<br>
<br>
pep8 <lots of files><br>
packaging/setup/plugins/ovirt-<wbr>engine-setup/ovirt-engine/<wbr>network/ovirtproviderovn.py:<wbr>474:25:<br>
E126 continuation line over-indented for hanging indent<br>
packaging/setup/plugins/ovirt-<wbr>engine-setup/ovirt-engine/<wbr>network/ovirtproviderovn.py:<wbr>481:25:<br>
E126 continuation line over-indented for hanging indent<br>
packaging/setup/plugins/ovirt-<wbr>engine-setup/ovirt-engine/<wbr>network/ovirtproviderovn.py:<wbr>488:25:<br>
E126 continuation line over-indented for hanging indent<br>
packaging/setup/plugins/ovirt-<wbr>engine-setup/ovirt-engine/<wbr>network/ovirtproviderovn.py:<wbr>635:21:<br>
E126 continuation line over-indented for hanging indent<br>
packaging/setup/plugins/ovirt-<wbr>engine-setup/ovirt-engine/<wbr>network/ovirtproviderovn.py:<wbr>637:21:<br>
E126 continuation line over-indented for hanging indent<br>
packaging/setup/plugins/ovirt-<wbr>engine-setup/ovirt-engine/<wbr>network/ovirtproviderovn.py:<wbr>639:21:<br>
E126 continuation line over-indented for hanging indent<br>
packaging/setup/plugins/ovirt-<wbr>engine-setup/ovirt-engine/<wbr>network/ovirtproviderovn.py:<wbr>641:21:<br>
E126 continuation line over-indented for hanging indent<br>
packaging/setup/plugins/ovirt-<wbr>engine-setup/ovirt-engine/<wbr>network/ovirtproviderovn.py:<wbr>645:21:<br>
E126 continuation line over-indented for hanging indent<br>
packaging/setup/plugins/ovirt-<wbr>engine-setup/ovirt-engine/<wbr>network/ovirtproviderovn.py:<wbr>652:21:<br>
E126 continuation line over-indented for hanging indent<br>
packaging/setup/plugins/ovirt-<wbr>engine-setup/ovirt-engine/<wbr>network/ovirtproviderovn.py:<wbr>654:21:<br>
E126 continuation line over-indented for hanging indent<br>
packaging/setup/plugins/ovirt-<wbr>engine-setup/ovirt-engine/<wbr>network/ovirtproviderovn.py:<wbr>658:21:<br>
E126 continuation line over-indented for hanging indent<br>
packaging/setup/plugins/ovirt-<wbr>engine-setup/ovirt-engine/<wbr>network/ovirtproviderovn.py:<wbr>663:21:<br>
E126 continuation line over-indented for hanging indent<br>
packaging/setup/plugins/ovirt-<wbr>engine-setup/ovirt-engine/<wbr>network/ovirtproviderovn.py:<wbr>664:21:<br>
E126 continuation line over-indented for hanging indent<br>
packaging/setup/plugins/ovirt-<wbr>engine-setup/ovirt-engine/<wbr>network/ovirtproviderovn.py:<wbr>872:13:<br>
E126 continuation line over-indented for hanging indent<br>
packaging/setup/plugins/ovirt-<wbr>engine-setup/ovirt-engine/db/<wbr>configuration.py:255:13:<br>
E126 continuation line over-indented for hanging indent<br>
packaging/setup/plugins/ovirt-<wbr>engine-rename/ovirt-engine/<wbr>database.py:313:21:<br>
E126 continuation line over-indented for hanging indent<br>
packaging/setup/plugins/ovirt-<wbr>engine-rename/ovirt-engine/<wbr>database.py:314:21:<br>
E126 continuation line over-indented for hanging indent<br>
packaging/setup/plugins/ovirt-<wbr>engine-common/base/core/<wbr>duplicated_constants_check.py:<wbr>109:17:<br>
E124 closing bracket does not match visual indentation<br>
+ ret=1<br>
<br>
Perhaps a newer version of pep8 finds more bugs in our code.<br>
<br>
Pushed this to get a more explanatory error:<br>
<br>
<a href="https://gerrit.ovirt.org/88186" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/88186</a><br>
<br>
Best regards,<br>
<br>
><br>
> With Best Regards.<br>
><br>
> Steven Rosenberg.<br>
><br>
> On Mon, Feb 26, 2018 at 3:10 PM, Yedidyah Bar David <<a href="mailto:didi@redhat.com">didi@redhat.com</a>> wrote:<br>
>><br>
>> Hi,<br>
>><br>
>> On Mon, Feb 26, 2018 at 2:39 PM, Steven Rosenberg <<a href="mailto:srosenbe@redhat.com">srosenbe@redhat.com</a>><br>
>> wrote:<br>
>> > Dear Martin,<br>
>> ><br>
>> > I should add I am running RHEL 7.4 (Maipo).<br>
>> ><br>
>> > With Best Regards.<br>
>> ><br>
>> > Steven Rosenberg.<br>
>> ><br>
>> > On Mon, Feb 26, 2018 at 2:24 PM, Martin Perina <<a href="mailto:mperina@redhat.com">mperina@redhat.com</a>><br>
>> > wrote:<br>
>> >><br>
>> >> Didi/Sandro, any ideas about it? AFAIK on CentOS/RHEL 7 everything<br>
>> >> works<br>
>> >> as expected ...<br>
>> >><br>
>> >><br>
>> >> On Mon, Feb 26, 2018 at 11:58 AM, Steven Rosenberg<br>
>> >> <<a href="mailto:srosenbe@redhat.com">srosenbe@redhat.com</a>><br>
>> >> wrote:<br>
>> >>><br>
>> >>> Dear Martin Perina,<br>
>> >>><br>
>> >>> We found some issues with the oVirt Engine master branch when updating<br>
>> >>> the version via git pull.<br>
>> >>><br>
>> >>> We then performed the make command:<br>
>> >>><br>
>> >>> make clean install-dev PREFIX=~/ovirt_engine_master<br>
>> >>> DEV_BUILD_SCL_POSTGRESQL=1<br>
>> >>><br>
>> >>> It seems a new dependency was added for isort, so the make fails with<br>
>> >>> the<br>
>> >>> following error:<br>
>> >>><br>
>> >>><br>
>> >>><br>
>> >>> ------------------------------<wbr>------------------------------<wbr>------------------------------<wbr>--------------------------<br>
>> >>><br>
>> >>><br>
>> >>><br>
>> >>> packaging/setup/plugins/ovirt-<wbr>engine-rename/ovirt-engine/<wbr>database.py:313:21:<br>
>> >>> E126 continuation line over-indented for hanging indent<br>
>> >>><br>
>> >>><br>
>> >>> packaging/setup/plugins/ovirt-<wbr>engine-rename/ovirt-engine/<wbr>database.py:314:21:<br>
>> >>> E126 continuation line over-indented for hanging indent<br>
>> >>><br>
>> >>><br>
>> >>> packaging/setup/plugins/ovirt-<wbr>engine-common/base/core/<wbr>duplicated_constants_check.py:<wbr>109:17:<br>
>> >>> E124 closing bracket does not match visual indentation<br>
>> >>> + ret=1<br>
>> >>> + which isort<br>
>> >>> + echo 'WARNING: tool '\''isort'\'' is missing'<br>
>> >>> WARNING: tool 'isort' is missing<br>
>><br>
>> This is just a warning<br>
>><br>
>> >>> + exit 1<br>
>><br>
>> Most likely the error causing it to exit 1 happened earlier, please<br>
>> check/share<br>
>> more of the output.<br>
>><br>
>> >>> make[1]: *** [validations] Error 1<br>
>> >>> make[1]: Leaving directory `/home/srosenbe/Documents/git/<wbr>ovirt-engine'<br>
>> >>> make: *** [all-dev] Error 2<br>
>> >>><br>
>> >>><br>
>> >>><br>
>> >>> ------------------------------<wbr>------------------------------<wbr>------------------------------<wbr>--------------------------<br>
>> >>><br>
>> >>> To attempt to address this issue, we guessed and installed<br>
>> >>> python2-isort<br>
>> >>> through yum, though the readme states it is optional.<br>
>> >>><br>
>> >>> Though the process continued, it then failed in the python module:<br>
>> >>><br>
>> >>><br>
>> >>><br>
>> >>> /home/srosenbe/Documents/git/<wbr>ovirt-engine/packaging/<wbr>pythonlib/ovirt_engine/<wbr>service.py<br>
>> >>><br>
>> >>> That error is here:<br>
>> >>><br>
>> >>><br>
>> >>><br>
>> >>> ------------------------------<wbr>------------------------------<wbr>------------------------------<wbr>------------------------------<wbr>---<br>
>> >>><br>
>> >>><br>
>> >>> ---<br>
>> >>><br>
>> >>> /home/srosenbe/Documents/git/<wbr>ovirt-engine/packaging/<wbr>pythonlib/ovirt_engine/<wbr>service.py:before<br>
>> >>> 2018-02-12 12:17:26<br>
>> >>> +++<br>
>> >>><br>
>> >>> /home/srosenbe/Documents/git/<wbr>ovirt-engine/packaging/<wbr>pythonlib/ovirt_engine/<wbr>service.py:after<br>
>> >>> 2018-02-26 12:07:11.233915<br>
>> >>> @@ -31,6 +31,7 @@<br>
>> >>> import time<br>
>> >>><br>
>> >>> import daemon<br>
>> >>> +<br>
>> >>><br>
>> >>> from dateutil import tz<br>
>> >>><br>
>><br>
>> This is an output of 'isort --diff', and not the actual error.<br>
>><br>
>> (isort --check, which is what we run to test the code, does not fail if<br>
>> the diff it would have suggested consists of only difference in the number<br>
>> of empty lines. It would still be nice to patch service.py to have another<br>
>> empty line, but not needed).<br>
>><br>
>> >>> + exit 1<br>
>><br>
>> Same. Error was most likely earlier.<br>
>><br>
>> Best regards,<br>
>><br>
>> >>> make[1]: *** [validations] Error 1<br>
>> >>> make[1]: Leaving directory `/home/srosenbe/Documents/git/<wbr>ovirt-engine'<br>
>> >>> make: *** [all-dev] Error 2<br>
>> >>><br>
>> >>><br>
>> >>><br>
>> >>> ------------------------------<wbr>------------------------------<wbr>------------------------------<wbr>------------------------------<wbr>---<br>
>> >>><br>
>> >>> Please advise if you have a quick fix or when this issue will be<br>
>> >>> addressed.<br>
>> >>><br>
>> >>> Thank you for your time and consideration.<br>
>> >>><br>
>> >>> With Best Regards.<br>
>> >>><br>
>> >>> Steven Rosenberg.<br>
>> >>><br>
>> >><br>
>> >><br>
>> >><br>
>> >> --<br>
>> >> Martin Perina<br>
>> >> Associate Manager, Software Engineering<br>
>> >> Red Hat Czech s.r.o.<br>
>> ><br>
>> ><br>
>><br>
>><br>
<span class="HOEnZb"><font color="#888888">>><br>
>> --<br>
>> Didi<br>
><br>
><br>
<br>
<br>
<br>
--<br>
Didi<br>
</font></span></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><font size="1">Martin Perina<br>Associate Manager, Software Engineering<br>Red Hat Czech s.r.o.<br></font></div></div>
</div>