<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On 13 Mar 2018, at 22:24, Dafna Ron <<a href="mailto:dron@redhat.com" class="">dron@redhat.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><br class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On Tue, Mar 13, 2018 at 10:57 AM, Michal Skrivanek <span dir="ltr" class=""><<a href="mailto:michal.skrivanek@redhat.com" target="_blank" class="">michal.skrivanek@redhat.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;" class=""><br class=""><div class=""><span class="gmail-"><br class=""><blockquote type="cite" class=""><div class="">On 13 Mar 2018, at 09:27, Eyal Edri <<a href="mailto:eedri@redhat.com" target="_blank" class="">eedri@redhat.com</a>> wrote:</div><br class="gmail-m_-1623607510736288965Apple-interchange-newline"><div class=""><div dir="ltr" class=""><br class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On Tue, Mar 13, 2018 at 9:29 AM, Dan Kenigsberg <span dir="ltr" class=""><<a href="mailto:danken@redhat.com" target="_blank" class="">danken@redhat.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="">On Mon, Mar 12, 2018 at 8:24 PM, Dafna Ron <<a href="mailto:dron@redhat.com" target="_blank" class="">dron@redhat.com</a>> wrote:<br class="">
> We just had a failure in master 002_bootstrap.add_mac_pool with the same<br class="">
> error on edit cluster.<br class=""></span></blockquote></div></div></div></div></blockquote><div class=""><br class=""></div></span>Does it fail consistently?</div></div></blockquote><div class=""><br class=""></div><div class="">yes. <br class=""></div></div></div></div></div></blockquote><div><br class=""></div>that’s good</div><div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><div class=""><br class=""> <br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;" class=""><div class="">Did you narrow down the commit(s) where it started to happen?</div></div></blockquote><div class=""><br class=""></div><div class="">First change reported failed by CQ on this issue is this one: <a href="https://gerrit.ovirt.org/#/c/88738/2" target="_blank" class="">https://gerrit.ovirt.org/#/c/<wbr class="">88738/2</a><span class="gmail-"> <br class=""></span> - db: add func to turn table columns to empty string (this was reported by Daniel at the beginning of this thread)<br class=""></div><div class=""><br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;" class=""><div class="">Was there any other update done at that time?</div><div class=""><br class=""></div></div></blockquote><div class="">there are always other changes submitted. but CQ tries to isolate the change that it believes is causing the failure by reducing the change it tests until it gets to one single change. <br class=""></div></div></div></div></div></blockquote><div><br class=""></div>I meant changes like major update of packages or any other configuration change<br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><div class=""><br class=""><br class=""></div><div class="">We cannot have OST keep failing for a long time, especially on a big project like ovirt-engine. if we cannot have a fix on this quickly I think we should start skipping failed tests to allow changes to pass successfully until the bug is fixed. <br class=""></div></div></div></div></div></blockquote><div><br class=""></div>sure. But in this case you’re just going to hit the same problem in the next test. Please enable back the one you commented out, and try to revert that patch instead. There is a chance it changed the behavior because somehow the tests using Default cluster somehow rely on undefined values (not sure if that’s even intentional, but that’s the way it is written), and that patch may have changed it perhaps. Eli?</div><div><br class=""></div><div>Thanks,</div><div>michal<br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><div class=""><br class=""></div><div class="">Thanks, <br class=""></div><div class="">Dafna<br class=""><br class=""></div><div class=""> <br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;" class=""><div class=""></div><div class="">Thanks,</div><div class="">michal</div><div class=""><div class="gmail-h5"><div class=""><br class=""></div><div class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="">
><br class="">
> <a href="http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/6259/testReport/%28root%29/002_bootstrap/add_mac_pool/" rel="noreferrer" target="_blank" class="">http://jenkins.ovirt.org/job/o<wbr class="">virt-master_change-queue-teste<wbr class="">r/6259/testReport/(root)/002_<wbr class="">bootstrap/add_mac_pool/</a><br class="">
><br class="">
> either I skipped the wrong test or we have a bigger issue.<br class="">
<br class="">
</span>We certainly do. As before, the error pops up on an attempt to update<br class="">
the cluster (this time it is changing only the mac pool of the<br class="">
cluster). CPU is not specified by the command, so it should not have<br class="">
changed at all. Still, something fills a CPU, and chooses a wrong<br class="">
value.<br class="">
<br class="">
cluster_service.update(<br class="">
cluster=sdk4.types.Cluster(<br class="">
mac_pool=sdk4.types.MacPool(<br class="">
id=<a href="http://pool.id/" rel="noreferrer" target="_blank" class="">pool.id</a>,<br class="">
)<br class="">
)<br class="">
)<br class="">
<br class="">
2018-03-12 13:58:56,263-04 WARN<br class="">
[org.ovirt.engine.core.bll.Upd<wbr class="">ateClusterCommand] (default task-19)<br class="">
[79d12090-a8e8-438c-bbce-1bf09<wbr class="">a42c5fb] Validation of action<br class="">
'UpdateCluster' failed for user admin@internal-authz. Reasons:<br class="">
VAR__TYPE__CLUSTER,VAR__ACTION<wbr class="">__UPDATE,ACTION_TYPE_FAILED_<wbr class="">CPU_NOT_FOUND,VAR__TYPE__<wbr class="">CLUSTER<br class="">
2018-03-12 13:58:56,264-04 INFO<br class="">
[org.ovirt.engine.core.bll.Upd<wbr class="">ateClusterCommand] (default task-19)<br class="">
[79d12090-a8e8-438c-bbce-1bf09<wbr class="">a42c5fb] Lock freed to object<br class="">
'EngineLock:{exclusiveLocks='[<wbr class="">]', sharedLocks='[]'}'<br class="">
2018-03-12 13:58:56,264-04 DEBUG<br class="">
[org.ovirt.engine.core.common.<wbr class="">di.interceptor.DebugLoggingInt<wbr class="">erceptor]<br class="">
(default task-19) [79d12090-a8e8-438c-bbce-1bf09<wbr class="">a42c5fb] method:<br class="">
runAction, params: [UpdateCluster,<br class="">
ManagementNetworkOnClusterOper<wbr class="">ationParameters:{commandId='be<wbr class="">be80f7-f8ca-4d01-aed8-28e463d0<wbr class="">f435',<br class="">
user='null', commandType='Unknown'}], timeElapsed: 50ms<br class="">
2018-03-12 13:58:56,269-04 ERROR<br class="">
[org.ovirt.engine.api.restapi.<wbr class="">resource.AbstractBackendResour<wbr class="">ce]<br class="">
(default task-19) [] Operation Failed: [Cannot edit Cluster. The<br class="">
<span class="gmail-m_-1623607510736288965im gmail-m_-1623607510736288965HOEnZb">chosen CPU is not supported.]<br class=""></span></blockquote><div class=""><br class=""></div><div class="">So I guess we can't skip this test as well, and this issue has to be fixed right? </div><div class=""><br class=""></div><div class=""> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-m_-1623607510736288965im gmail-m_-1623607510736288965HOEnZb">
</span><div class="gmail-m_-1623607510736288965HOEnZb"><div class="gmail-m_-1623607510736288965h5">______________________________<wbr class="">_________________<br class="">
Devel mailing list<br class="">
<a href="mailto:Devel@ovirt.org" target="_blank" class="">Devel@ovirt.org</a><br class="">
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank" class="">http://lists.ovirt.org/mailman<wbr class="">/listinfo/devel</a><br class="">
</div></div></blockquote></div><br class=""><br clear="all" class=""><div class=""><br class=""></div>-- <br class=""><div class="gmail-m_-1623607510736288965gmail_signature"><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div class=""><div dir="ltr" class=""><div class=""><div style="font-family:overpass,sans-serif;margin:0px;padding:0px;font-size:14px;text-transform:uppercase;font-weight:bold" class=""><font color="#cc0000" class="">Eyal edri</font></div><div style="font-family:overpass,sans-serif;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase" class=""><br class=""></div><p style="font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase" class="">MANAGER</p><p style="font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase" class="">RHV DevOps</p><p style="font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase" class="">EMEA VIRTUALIZATION R&D</p><p style="font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase" class=""><br class=""></p><div style="font-family:overpass,sans-serif;margin:0px;font-size:10px;color:rgb(153,153,153)" class=""><a href="https://www.redhat.com/" style="color:rgb(0,136,206);margin:0px" target="_blank" class="">Red Hat EMEA</a></div><table style="font-family:overpass,sans-serif;font-size:inherit" border="0" class=""><tbody class=""><tr class=""><td width="100px" class=""><a href="https://red.ht/sig" style="color:rgb(17,85,204)" target="_blank" class=""><img src="https://www.redhat.com/profiles/rh/themes/redhatdotcom/img/logo-red-hat-black.png" width="90" height="auto" class=""></a></td><td style="font-size:10px" class=""><a href="https://redhat.com/trusted" style="color:rgb(204,0,0);font-weight:bold" target="_blank" class="">TRIED. TESTED. TRUSTED.</a></td></tr></tbody></table></div><div class="">phone: <a href="tel:+972%209-769-2018" value="+97297692018" target="_blank" class="">+972-9-7692018</a><br class="">irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div></div></div></div></div></div></div>
</div></div>
______________________________<wbr class="">_________________<br class="">Devel mailing list<br class=""><a href="mailto:Devel@ovirt.org" target="_blank" class="">Devel@ovirt.org</a><br class=""><a href="http://lists.ovirt.org/mailman/listinfo/devel" target="_blank" class="">http://lists.ovirt.org/<wbr class="">mailman/listinfo/devel</a></div></blockquote></div><br class=""></div></div></div></blockquote></div><br class=""></div></div>
</div></blockquote></div><br class=""></body></html>