<div dir="ltr">I've backported to 4.2, kind reviewers from master please review as well - <a href="https://gerrit.ovirt.org/#/c/89035/">https://gerrit.ovirt.org/#/c/89035/</a><div><br></div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Mar 15, 2018 at 11:18 AM, Tal Nisan <span dir="ltr"><<a href="mailto:tnisan@redhat.com" target="_blank">tnisan@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Thanks to the reviewers, merged on master now.<div>Working with Dafna on getting it fixed on 4.2 and understanding whether 4.1.10 is affected (probably the most important question as we've already built it and it should be shipped to customers).</div><div><br></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Mar 15, 2018 at 10:11 AM, Tal Nisan <span dir="ltr"><<a href="mailto:tnisan@redhat.com" target="_blank">tnisan@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I've reviewed and marked +1, I'll need another reviewer though for this matter.<div>I've also based one of my patches on top of it and it passed OST:</div><div><a href="http://jenkins.ovirt.org/view/oVirt%20system%20tests/job/ovirt-system-tests_manual/2387/" target="_blank">http://jenkins.ovirt.org/view/<wbr>oVirt%20system%20tests/job/ovi<wbr>rt-system-tests_manual/2387/</a><br></div><div><br></div><div>Dafna, prior to Eli's patch all OST jobs failed?</div><div><br></div></div><div class="m_8557269164058131054HOEnZb"><div class="m_8557269164058131054h5"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Mar 14, 2018 at 6:46 PM, Dafna Ron <span dir="ltr"><<a href="mailto:dron@redhat.com" target="_blank">dron@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div>Eli updated the bug with a fix that reverts parts of the reported patch: <a href="https://gerrit.ovirt.org/#/c/89005/" target="_blank">https://gerrit.ovirt.org/#/c/8<wbr>9005/</a><br><br></div>waiting for verification and merge. <br><br></div>Thanks!<span class="m_8557269164058131054m_-1351392517603995307HOEnZb"><font color="#888888"><br></font></span></div><span class="m_8557269164058131054m_-1351392517603995307HOEnZb"><font color="#888888">Dafna<br><br><div><div><div><div><br><br></div></div></div></div></font></span></div><div class="m_8557269164058131054m_-1351392517603995307HOEnZb"><div class="m_8557269164058131054m_-1351392517603995307h5"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Mar 13, 2018 at 9:49 PM, Dafna Ron <span dir="ltr"><<a href="mailto:dron@redhat.com" target="_blank">dron@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span>On Tue, Mar 13, 2018 at 9:32 PM, Michal Skrivanek <span dir="ltr"><<a href="mailto:michal.skrivanek@redhat.com" target="_blank">michal.skrivanek@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space"><br><div><span><br><blockquote type="cite"><div>On 13 Mar 2018, at 22:24, Dafna Ron <<a href="mailto:dron@redhat.com" target="_blank">dron@redhat.com</a>> wrote:</div><br class="m_8557269164058131054m_-1351392517603995307m_-2645234401371151016m_831181208142520154m_4817605265933923136Apple-interchange-newline"><div><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Mar 13, 2018 at 10:57 AM, Michal Skrivanek <span dir="ltr"><<a href="mailto:michal.skrivanek@redhat.com" target="_blank">michal.skrivanek@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><br><div><span class="m_8557269164058131054m_-1351392517603995307m_-2645234401371151016m_831181208142520154m_4817605265933923136gmail-"><br><blockquote type="cite"><div>On 13 Mar 2018, at 09:27, Eyal Edri <<a href="mailto:eedri@redhat.com" target="_blank">eedri@redhat.com</a>> wrote:</div><br class="m_8557269164058131054m_-1351392517603995307m_-2645234401371151016m_831181208142520154m_4817605265933923136gmail-m_-1623607510736288965Apple-interchange-newline"><div><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Mar 13, 2018 at 9:29 AM, Dan Kenigsberg <span dir="ltr"><<a href="mailto:danken@redhat.com" target="_blank">danken@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span>On Mon, Mar 12, 2018 at 8:24 PM, Dafna Ron <<a href="mailto:dron@redhat.com" target="_blank">dron@redhat.com</a>> wrote:<br>
> We just had a failure in master 002_bootstrap.add_mac_pool with the same<br>
> error on edit cluster.<br></span></blockquote></div></div></div></div></blockquote><div><br></div></span>Does it fail consistently?</div></div></blockquote><div><br></div><div>yes. <br></div></div></div></div></div></blockquote><div><br></div></span>that’s good</div><div><span><br><blockquote type="cite"><div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div>Did you narrow down the commit(s) where it started to happen?</div></div></blockquote><div><br></div><div>First change reported failed by CQ on this issue is this one: <a href="https://gerrit.ovirt.org/#/c/88738/2" target="_blank">https://gerrit.ovirt.org/#/c/8<wbr>8738/2</a><span class="m_8557269164058131054m_-1351392517603995307m_-2645234401371151016m_831181208142520154m_4817605265933923136gmail-"> <br></span> - db: add func to turn table columns to empty string (this was reported by Daniel at the beginning of this thread)<br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div>Was there any other update done at that time?</div><div><br></div></div></blockquote><div>there are always other changes submitted. but CQ tries to isolate the change that it believes is causing the failure by reducing the change it tests until it gets to one single change. <br></div></div></div></div></div></blockquote><div><br></div></span>I meant changes like major update of packages or any other configuration change<span><br></span></div></div></blockquote><div><br></div></span><div>:) the last one I saw was from Eli on Friday but I don't think its related. since this is a big project and there a lot of changes submitted daily, maybe someone more qualified them me can have a look and see if anything catches their eyes? <br></div><span><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space"><div><span><blockquote type="cite"><div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br><br></div><div>We cannot have OST keep failing for a long time, especially on a big project like ovirt-engine. if we cannot have a fix on this quickly I think we should start skipping failed tests to allow changes to pass successfully until the bug is fixed. <br></div></div></div></div></div></blockquote><div><br></div></span>sure. But in this case you’re just going to hit the same problem in the next test. Please enable back the one you commented out, and try to revert that patch instead. There is a chance it changed the behavior because somehow the tests using Default cluster somehow rely on undefined values (not sure if that’s even intentional, but that’s the way it is written), and that patch may have changed it perhaps. Eli?</div><div><br></div></div></blockquote></span><div>cool. I think that Eyal has reverted my skip test so we can try to revert the change reported. <br> <br></div><div><div class="m_8557269164058131054m_-1351392517603995307m_-2645234401371151016h5"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space"><div></div><div>Thanks,</div><div>michal<div><div class="m_8557269164058131054m_-1351392517603995307m_-2645234401371151016m_831181208142520154h5"><br><blockquote type="cite"><div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><div>Thanks, <br></div><div>Dafna<br><br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div></div><div>Thanks,</div><div>michal</div><div><div class="m_8557269164058131054m_-1351392517603995307m_-2645234401371151016m_831181208142520154m_4817605265933923136gmail-h5"><div><br></div><div><blockquote type="cite"><div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span>
><br>
> <a href="http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/6259/testReport/%28root%29/002_bootstrap/add_mac_pool/" rel="noreferrer" target="_blank">http://jenkins.ovirt.org/job/o<wbr>virt-master_change-queue-teste<wbr>r/6259/testReport/(root)/002_b<wbr>ootstrap/add_mac_pool/</a><br>
><br>
> either I skipped the wrong test or we have a bigger issue.<br>
<br>
</span>We certainly do. As before, the error pops up on an attempt to update<br>
the cluster (this time it is changing only the mac pool of the<br>
cluster). CPU is not specified by the command, so it should not have<br>
changed at all. Still, something fills a CPU, and chooses a wrong<br>
value.<br>
<br>
cluster_service.update(<br>
cluster=sdk4.types.Cluster(<br>
mac_pool=sdk4.types.MacPool(<br>
id=<a href="http://pool.id/" rel="noreferrer" target="_blank">pool.id</a>,<br>
)<br>
)<br>
)<br>
<br>
2018-03-12 13:58:56,263-04 WARN<br>
[org.ovirt.engine.core.bll.Upd<wbr>ateClusterCommand] (default task-19)<br>
[79d12090-a8e8-438c-bbce-1bf09<wbr>a42c5fb] Validation of action<br>
'UpdateCluster' failed for user admin@internal-authz. Reasons:<br>
VAR__TYPE__CLUSTER,VAR__ACTION<wbr>__UPDATE,ACTION_TYPE_FAILED_CP<wbr>U_NOT_FOUND,VAR__TYPE__CLUSTER<br>
2018-03-12 13:58:56,264-04 INFO<br>
[org.ovirt.engine.core.bll.Upd<wbr>ateClusterCommand] (default task-19)<br>
[79d12090-a8e8-438c-bbce-1bf09<wbr>a42c5fb] Lock freed to object<br>
'EngineLock:{exclusiveLocks='[<wbr>]', sharedLocks='[]'}'<br>
2018-03-12 13:58:56,264-04 DEBUG<br>
[org.ovirt.engine.core.common.<wbr>di.interceptor.DebugLoggingInt<wbr>erceptor]<br>
(default task-19) [79d12090-a8e8-438c-bbce-1bf09<wbr>a42c5fb] method:<br>
runAction, params: [UpdateCluster,<br>
ManagementNetworkOnClusterOper<wbr>ationParameters:{commandId='be<wbr>be80f7-f8ca-4d01-aed8-28e463d0<wbr>f435',<br>
user='null', commandType='Unknown'}], timeElapsed: 50ms<br>
2018-03-12 13:58:56,269-04 ERROR<br>
[org.ovirt.engine.api.restapi.<wbr>resource.AbstractBackendResour<wbr>ce]<br>
(default task-19) [] Operation Failed: [Cannot edit Cluster. The<br>
<span class="m_8557269164058131054m_-1351392517603995307m_-2645234401371151016m_831181208142520154m_4817605265933923136gmail-m_-1623607510736288965im m_8557269164058131054m_-1351392517603995307m_-2645234401371151016m_831181208142520154m_4817605265933923136gmail-m_-1623607510736288965HOEnZb">chosen CPU is not supported.]<br></span></blockquote><div><br></div><div>So I guess we can't skip this test as well, and this issue has to be fixed right? </div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="m_8557269164058131054m_-1351392517603995307m_-2645234401371151016m_831181208142520154m_4817605265933923136gmail-m_-1623607510736288965im m_8557269164058131054m_-1351392517603995307m_-2645234401371151016m_831181208142520154m_4817605265933923136gmail-m_-1623607510736288965HOEnZb">
</span><div class="m_8557269164058131054m_-1351392517603995307m_-2645234401371151016m_831181208142520154m_4817605265933923136gmail-m_-1623607510736288965HOEnZb"><div class="m_8557269164058131054m_-1351392517603995307m_-2645234401371151016m_831181208142520154m_4817605265933923136gmail-m_-1623607510736288965h5">______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="m_8557269164058131054m_-1351392517603995307m_-2645234401371151016m_831181208142520154m_4817605265933923136gmail-m_-1623607510736288965gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div style="font-family:overpass,sans-serif;margin:0px;padding:0px;font-size:14px;text-transform:uppercase;font-weight:bold"><font color="#cc0000">Eyal edri</font></div><div style="font-family:overpass,sans-serif;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase"><br></div><p style="font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase">MANAGER</p><p style="font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase">RHV DevOps</p><p style="font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase">EMEA VIRTUALIZATION R&D</p><p style="font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase"><br></p><div style="font-family:overpass,sans-serif;margin:0px;font-size:10px;color:rgb(153,153,153)"><a href="https://www.redhat.com/" style="color:rgb(0,136,206);margin:0px" target="_blank">Red Hat EMEA</a></div><table style="font-family:overpass,sans-serif;font-size:inherit" border="0"><tbody><tr><td width="100px"><a href="https://red.ht/sig" style="color:rgb(17,85,204)" target="_blank"><img src="https://www.redhat.com/profiles/rh/themes/redhatdotcom/img/logo-red-hat-black.png" width="90" height="auto"></a></td><td style="font-size:10px"><a href="https://redhat.com/trusted" style="color:rgb(204,0,0);font-weight:bold" target="_blank">TRIED. TESTED. TRUSTED.</a></td></tr></tbody></table></div><div>phone: <a href="tel:+972%209-769-2018" value="+97297692018" target="_blank">+972-9-7692018</a><br>irc: eedri (on #tlv #rhev-dev #rhev-integ)</div></div></div></div></div></div></div></div></div></div></div>
</div></div>
______________________________<wbr>_________________<br>Devel mailing list<br><a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br><a href="http://lists.ovirt.org/mailman/listinfo/devel" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a></div></blockquote></div><br></div></div></div></blockquote></div><br></div></div>
</div></blockquote></div></div></div><br></div></blockquote></div></div></div><br></div></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>