<div dir="ltr"><div><div><div>Thanks Beni. <br><br></div>can you please paste the fix that you submit to the mail? <br><br></div>Thanks, <br></div>Dafna<br><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Mar 28, 2018 at 9:13 AM, Benny Zlotnik <span dir="ltr"><<a href="mailto:bzlotnik@redhat.com" target="_blank">bzlotnik@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">This issue looks like it's caused by the DB lock being released before the engine memory lock, there was a similar race with the LSM test a few months back. I'll apply the same fix for the snapshot_cold_merge.<br>. <br></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Mar 27, 2018 at 10:03 PM, Benny Zlotnik <span dir="ltr"><<a href="mailto:bzlotnik@redhat.com" target="_blank">bzlotnik@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Looking into this<br></div><div class="m_6780514725499124064HOEnZb"><div class="m_6780514725499124064h5"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Mar 27, 2018 at 6:45 PM, Dafna Ron <span dir="ltr"><<a href="mailto:dron@redhat.com" target="_blank">dron@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Hi, <br><br></div>We have a failure on 004_basic_sanity.disk_operatio<wbr>ns. the reported change seems to me to be connected to the failure. <br><br><b style="font-weight:normal" id="m_6780514725499124064m_-5229015095407386597m_7368661571786050948gmail-docs-internal-guid-e8ba4241-681a-ed3b-8fdc-10a6411cfc7b"><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;font-weight:400;font-style:normal;font-variant:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap">Link and headline of suspected patches: <br></span></p><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;font-weight:400;font-style:normal;font-variant:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap">core: introduce CreateSnapshotForVm - <a href="https://gerrit.ovirt.org/#/c/87671/" target="_blank">https://gerrit.ovirt.org/#/c/8<wbr>7671/</a></span></p><br><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;font-weight:400;font-style:normal;font-variant:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap">Link to Job:</span></p><a href="http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/6564/" target="_blank">http://jenkins.ovirt.org/job/o<wbr>virt-master_change-queue-teste<wbr>r/6564/</a><br><br><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;font-weight:400;font-style:normal;font-variant:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap">Link to all logs:</span></p><a href="http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/6564/artifact/exported-artifacts/basic-suit-master-el7/test_logs/basic-suite-master/post-004_basic_sanity.py/" target="_blank">http://jenkins.ovirt.org/job/o<wbr>virt-master_change-queue-teste<wbr>r/6564/artifact/exported-artif<wbr>acts/basic-suit-master-el7/tes<wbr>t_logs/basic-suite-master/post<wbr>-004_basic_sanity.py/</a><br><br><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;font-weight:400;font-style:normal;font-variant:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap">(Relevant) error snippet from the log: </span></p><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;font-weight:400;font-style:normal;font-variant:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap"><error></span></p><br>2018-03-27 11:30:16,167-04 WARN [org.ovirt.engine.core.bll.sna<wbr>pshots.CreateSnapshotForVmComm<wbr>and] (default task-11) [9f713a3d-82a9-4db8-8207-bb69a<wbr>0a2c550] Validation of action 'CreateSnapshotForVm' failed for user admin@internal-authz. Re<br>asons: VAR__ACTION__CREATE,VAR__TYPE_<wbr>_SNAPSHOT,ACTION_TYPE_FAILED_S<wbr>NAPSHOT_IS_BEING_TAKEN_FOR_VM,<wbr>$VmName vm1<br>2018-03-27 11:30:16,176-04 DEBUG [org.ovirt.engine.core.common.<wbr>di.interceptor.DebugLoggingInt<wbr>erceptor] (default task-11) [9f713a3d-82a9-4db8-8207-bb69a<wbr>0a2c550] method: runAction, params: [CreateSnapshotForVm, CreateSnapshotForVmParameters<br>:{commandId='d8bfdb0e-5ae4-4fe<wbr>d-8852-a0b29e377708', user='null', commandType='Unknown', vmId='65e7fea5-8b7d-4281-bd0d-<wbr>6a84de207a00'}], timeElapsed: 57ms<br>2018-03-27 11:30:16,186-04 ERROR [org.ovirt.engine.api.restapi.<wbr>resource.AbstractBackendResour<wbr>ce] (default task-11) [] Operation Failed: [Cannot create Snapshot. Snapshot is currently being created for VM vm1.]<br>2018-03-27 11:30:16,820-04 INFO [org.ovirt.engine.core.bll.Ser<wbr>ialChildCommandsExecutionCallb<wbr>ack] (EE-ManagedThreadFactory-engin<wbr>eScheduled-Thread-100) [16c08ce6-9a73-489f-a1f2-56e21<wbr>699f14a] Command 'CopyImageGroupVolumesData' (id: '4c4023<br>b4-21e8-4a98-8ac3-aba51967d160<wbr>') waiting on child command id: '3d96b933-6e3b-4838-94bc-db3ff<wbr>0cadcdc' type:'CopyData' to complete<br>2018-03-27 11:30:16,833-04 DEBUG [org.ovirt.engine.core.common.<wbr>di.interceptor.DebugLoggingInt<wbr>erceptor] (EE-ManagedThreadFactory-engin<wbr>eScheduled-Thread-100) [16c08ce6-9a73-489f-a1f2-56e21<wbr>699f14a] method: get, params: [a85992e9-40b8-4c80-9c<br>93-3bf767f6efa4], timeElapsed: 8ms<br><br><br><p dir="ltr" style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;font-weight:400;font-style:normal;font-variant:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap"></error></span></p></b><br class="m_6780514725499124064m_-5229015095407386597m_7368661571786050948gmail-Apple-interchange-newline"></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>