<div dir="ltr"><br><div class="gmail_quote"><div dir="ltr">On Thu, Mar 29, 2018 at 7:17 PM Dan Kenigsberg <<a href="mailto:danken@redhat.com">danken@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Wed, Mar 28, 2018 at 8:08 PM, Nir Soffer <<a href="mailto:nsoffer@redhat.com" target="_blank">nsoffer@redhat.com</a>> wrote:<br>
> On Wed, Mar 28, 2018 at 10:15 AM Dan Kenigsberg <<a href="mailto:danken@redhat.com" target="_blank">danken@redhat.com</a>> wrote:<br>
>><br>
>> I suppose this test should be reworked, or at least, have its constants<br>
>> tweaked.<br>
>><br>
>> FAIL: test_slow_handler_sync (common.logutils_test.TestThreadedHandler)<br>
>> ----------------------------------------------------------------------<br>
>> Traceback (most recent call last):<br>
>> File<br>
>> "/home/jenkins/workspace/vdsm_master_check-patch-fc27-x86_64/vdsm/tests/common/logutils_test.py",<br>
>> line 319, in test_slow_handler_sync<br>
>> self.assertGreater(max(workers_time), 0.9)<br>
>> AssertionError: 0.8714249134063721 not greater than 0.9<br>
><br>
><br>
> I tried to fix this last week, but for some reason the fix does not help on<br>
> the CI.<br>
><br>
> I think we can remove this test, it is reproducing the issues with the<br>
> standard<br>
> logging code, and does not test the new code.<br>
<br>
Ok: <a href="https://gerrit.ovirt.org/89618" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/89618</a></blockquote><div><br></div><div>Thanks, akced. </div></div></div>