<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;color:#000000">+Elad</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Apr 11, 2018 at 4:28 PM, Dan Kenigsberg <span dir="ltr"><<a href="mailto:danken@redhat.com" target="_blank">danken@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, Apr 11, 2018 at 12:34 PM, Nir Soffer <span dir="ltr"><<a href="mailto:nsoffer@redhat.com" target="_blank">nsoffer@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><span class="m_4163442653468676304gmail-"><div dir="ltr">On Wed, Apr 11, 2018 at 12:31 PM Eyal Edri <<a href="mailto:eedri@redhat.com" target="_blank">eedri@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Please make sure to run as much OST suites on this patch as possible before merging ( using 'ci please build' )</div></blockquote><div><br></div></span><div>But note that OST is not a way to verify the patch.</div><div><br></div><div>Such changes require testing with all storage types we support.</div><span class="m_4163442653468676304gmail-HOEnZb"><font color="#888888"><div> </div><div>Nir</div></font></span><div><div class="m_4163442653468676304gmail-h5"><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="gmail_extra"><div class="gmail_quote">On Tue, Apr 10, 2018 at 4:09 PM, Martin Polednik <span dir="ltr"><<a href="mailto:mpolednik@redhat.com" target="_blank">mpolednik@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hey,<br>
<br>
I've created a patch[0] that is finally able to activate libvirt's<br>
dynamic_ownership for VDSM while not negatively affecting<br>
functionality of our storage code.<br>
<br>
That of course comes with quite a bit of code removal, mostly in the<br>
area of host devices, hwrng and anything that touches devices; bunch<br>
of test changes and one XML generation caveat (storage is handled by<br>
VDSM, therefore disk relabelling needs to be disabled on the VDSM<br>
level).<br>
<br>
Because of the scope of the patch, I welcome storage/virt/network<br>
people to review the code and consider the implication this change has<br>
on current/future features.<br>
<br>
[0] <a href="https://gerrit.ovirt.org/#/c/89830/" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/8<wbr>9830/</a><br></blockquote></div></div></blockquote></div></div></div></div></blockquote><div><br></div><div>In particular: dynamic_ownership was set to 0 prehistorically (as part of <a href="https://bugzilla.redhat.com/show_bug.cgi?id=554961" target="_blank">https://bugzilla.redhat.com/<wbr>show_bug.cgi?id=554961</a> ) because libvirt, running as root, was not able to play properly with root-squash nfs mounts.<br><br></div><div>Have you attempted this use case?<br><br></div><div>I join to Nir's request to run this with storage QE.<br></div></div></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><br></div><div dir="ltr"><span style="font-family:arial,helvetica,sans-serif;font-size:small"><font color="#cccccc"><br></font></span></div><div dir="ltr"><font color="#999999"><span style="font-family:arial,helvetica,sans-serif;font-size:small">Raz Tamir</span><br></font></div><div><font face="arial, helvetica, sans-serif" size="2" color="#999999">Manager, RHV QE</font><span style="color:rgb(102,102,102);font-family:arial,helvetica,sans-serif;font-size:small"><br></span></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div>
</div>