<div dir="ltr"><div class="gmail_default" style="font-family:tahoma,sans-serif;font-size:small">A patch was uploaded: <a href="https://gerrit.ovirt.org/#/c/90093/">https://gerrit.ovirt.org/#/c/90093/</a><br></div></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><span style="font-family:tahoma,sans-serif"><b>Regards,<br></b></span></div><span style="font-family:tahoma,sans-serif"><b>Shani Leviim<br></b></span></div></div></div></div></div>
<br><div class="gmail_quote">On Wed, Apr 11, 2018 at 9:59 AM, Shani Leviim <span dir="ltr"><<a href="mailto:sleviim@redhat.com" target="_blank">sleviim@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="font-family:tahoma,sans-serif;font-size:small">HI,<br><br></div><div class="gmail_extra"><br clear="all"><div><div class="m_5556894770822102528gmail-m_-444527886967023366gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><span style="font-family:tahoma,sans-serif"><b>Regards,<br></b></span></div><span style="font-family:tahoma,sans-serif"><b>Shani Leviim<br></b></span></div></div></div></div></div>
<br><div class="gmail_quote"><span class="">On Tue, Apr 10, 2018 at 5:32 PM, Nir Soffer <span dir="ltr"><<a href="mailto:nsoffer@redhat.com" target="_blank">nsoffer@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><span><div dir="ltr">On Tue, Apr 10, 2018 at 5:21 PM Shani Leviim <<a href="mailto:sleviim@redhat.com" target="_blank">sleviim@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div style="font-family:tahoma,sans-serif;font-size:small">Hi,<br><br></div><div style="font-family:tahoma,sans-serif;font-size:small">Yes, I did clean the root directory but it didn't solve the issue.<br></div><div style="font-family:tahoma,sans-serif;font-size:small">I'm currently running the tests on fedora27, using python version 2.1.14.<br><br></div><div style="font-family:tahoma,sans-serif;font-size:small">Thanks to Dan's help, it seems that we found the root cause:<br></div><div style="font-family:tahoma,sans-serif;font-size:small"><br>I had 2 pickle files under /var/cache/vdsm/schema: vdsm-api.pickle and vdsm-events.pickle.<br></div><div style="font-family:tahoma,sans-serif;font-size:small">Removing them and re-running the tests using make check was successfully completed.<br></div></div></blockquote><div><br></div></span><div>How did you have cached schema under /var/run? This directory is owned by root.</div><div>Are you running the tests as root?</div></div></div></blockquote></span><div style="font-family:tahoma,sans-serif;font-size:small" class="gmail_default">No, I'm running the tests over my laptop using my user.</div><span class=""><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div><br></div><div>This sounds like a bug in the code using the pickled schema. The pickled should not</div><div>be used if the timestamp of the pickle do not match the timestamp of the source.</div></div></div></blockquote></span><div><div style="font-family:tahoma,sans-serif;font-size:small;display:inline" class="gmail_default"><br>There's a suspect that there's a different encoding for python 2 and python 3.<br></div><div style="font-family:tahoma,sans-serif;font-size:small;display:inline" class="gmail_default">While I checnged "with open(pickle_path) as f:" to "with open(pickle_path,'rb') as f: " (I was inspiered by [1]),<br></div><div style="font-family:tahoma,sans-serif;font-size:small;display:inline" class="gmail_default">the make check seems to complete successfully.<br></div><div style="font-family:tahoma,sans-serif;font-size:small;display:inline" class="gmail_default"></div> <br><div style="font-family:tahoma,sans-serif;font-size:small" class="gmail_default">[1] <a href="https://stackoverflow.com/questions/28218466/unpickling-a-python-2-object-with-python-3" target="_blank">https://stackoverflow.com/<wbr>questions/28218466/unpickling-<wbr>a-python-2-object-with-python-<wbr>3</a></div><br></div><span class=""><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div><br></div><div>Also in make check, we should not use host schema cache, but local schema cache</div><div>generated by running "make".</div><span class="m_5556894770822102528gmail-m_-444527886967023366HOEnZb"><font color="#888888"><div><br></div><div>Nir</div></font></span></div></div>
</blockquote></span></div><br></div></div>
</blockquote></div><br></div>