<div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Wed, Apr 11, 2018 at 3:30 PM Martin Polednik <<a href="mailto:mpolednik@redhat.com">mpolednik@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 11/04/18 12:27 +0000, Nir Soffer wrote:<br>
>On Wed, Apr 11, 2018 at 12:38 PM Eyal Edri <<a href="mailto:eedri@redhat.com" target="_blank">eedri@redhat.com</a>> wrote:<br>
><br>
>> On Wed, Apr 11, 2018 at 12:34 PM, Nir Soffer <<a href="mailto:nsoffer@redhat.com" target="_blank">nsoffer@redhat.com</a>> wrote:<br>
>><br>
>>> On Wed, Apr 11, 2018 at 12:31 PM Eyal Edri <<a href="mailto:eedri@redhat.com" target="_blank">eedri@redhat.com</a>> wrote:<br>
>>><br>
>>>> Please make sure to run as much OST suites on this patch as possible<br>
>>>> before merging ( using 'ci please build' )<br>
>>>><br>
>>><br>
>>> But note that OST is not a way to verify the patch.<br>
>>><br>
>>> Such changes require testing with all storage types we support.<br>
>>><br>
>><br>
>> Well, we already have HE suite that runs on ISCSI, so at least we have<br>
>> NFS+ISCSI on nested,<br>
>> for real storage testing, you'll have to do it manually<br>
>><br>
><br>
>We need glusterfs (both native and fuse based), and cinder/ceph storage.<br>
><br>
>But we cannot practically test all flows with all types of storage for<br>
>every patch.<br>
<br>
That leads to a question - how do I go around verifying such patch<br>
without sufficient environment? Is there someone from storage QA that<br>
could assist with this?<br></blockquote><div><br></div><div>Good question!</div><div><br></div><div>I hope Denis can help with verifying the glusterfs changes.</div><div><br></div><div>With cinder/ceph, maybe Elad can provide a setup for testing, or run some</div><div>automation tests on the patch?</div><div><br></div><div>Elad also have other automated tests for NFS/iSCSI that are worth running</div><div>before we merge such changes.</div><div><br></div><div>Nir</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
>Nir<br>
><br>
><br>
>><br>
>><br>
>>><br>
>>> Nir<br>
>>><br>
>>> On Tue, Apr 10, 2018 at 4:09 PM, Martin Polednik <<a href="mailto:mpolednik@redhat.com" target="_blank">mpolednik@redhat.com</a>><br>
>>>> wrote:<br>
>>>><br>
>>>>> Hey,<br>
>>>>><br>
>>>>> I've created a patch[0] that is finally able to activate libvirt's<br>
>>>>> dynamic_ownership for VDSM while not negatively affecting<br>
>>>>> functionality of our storage code.<br>
>>>>><br>
>>>>> That of course comes with quite a bit of code removal, mostly in the<br>
>>>>> area of host devices, hwrng and anything that touches devices; bunch<br>
>>>>> of test changes and one XML generation caveat (storage is handled by<br>
>>>>> VDSM, therefore disk relabelling needs to be disabled on the VDSM<br>
>>>>> level).<br>
>>>>><br>
>>>>> Because of the scope of the patch, I welcome storage/virt/network<br>
>>>>> people to review the code and consider the implication this change has<br>
>>>>> on current/future features.<br>
>>>>><br>
>>>>> [0] <a href="https://gerrit.ovirt.org/#/c/89830/" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/89830/</a><br>
>>>>><br>
>>>>> mpolednik<br>
>>>>> _______________________________________________<br>
>>>>> Devel mailing list<br>
>>>>> <a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
>>>>> <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br>
>>>>><br>
>>>><br>
>>>><br>
>>>><br>
>>>> --<br>
>>>><br>
>>>> Eyal edri<br>
>>>><br>
>>>><br>
>>>> MANAGER<br>
>>>><br>
>>>> RHV DevOps<br>
>>>><br>
>>>> EMEA VIRTUALIZATION R&D<br>
>>>><br>
>>>><br>
>>>> Red Hat EMEA <<a href="https://www.redhat.com/" rel="noreferrer" target="_blank">https://www.redhat.com/</a>><br>
>>>> <<a href="https://red.ht/sig" rel="noreferrer" target="_blank">https://red.ht/sig</a>> TRIED. TESTED. TRUSTED.<br>
>>>> <<a href="https://redhat.com/trusted" rel="noreferrer" target="_blank">https://redhat.com/trusted</a>><br>
>>>> phone: <a href="tel:+972%209-769-2018" value="+97297692018" target="_blank">+972-9-7692018</a> <+972%209-769-2018><br>
>>>> irc: eedri (on #tlv #rhev-dev #rhev-integ)<br>
>>>> _______________________________________________<br>
>>>> Devel mailing list<br>
>>>> <a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
>>>> <a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/devel</a><br>
>>><br>
>>><br>
>><br>
>><br>
>> --<br>
>><br>
>> Eyal edri<br>
>><br>
>><br>
>> MANAGER<br>
>><br>
>> RHV DevOps<br>
>><br>
>> EMEA VIRTUALIZATION R&D<br>
>><br>
>><br>
>> Red Hat EMEA <<a href="https://www.redhat.com/" rel="noreferrer" target="_blank">https://www.redhat.com/</a>><br>
>> <<a href="https://red.ht/sig" rel="noreferrer" target="_blank">https://red.ht/sig</a>> TRIED. TESTED. TRUSTED. <<a href="https://redhat.com/trusted" rel="noreferrer" target="_blank">https://redhat.com/trusted</a>><br>
>> phone: <a href="tel:+972%209-769-2018" value="+97297692018" target="_blank">+972-9-7692018</a> <+972%209-769-2018><br>
>> irc: eedri (on #tlv #rhev-dev #rhev-integ)<br>
>><br>
</blockquote></div></div>