<div dir="ltr">Suggested fix: <a href="https://gerrit.ovirt.org/#/c/90376/">https://gerrit.ovirt.org/#/c/90376/</a><br>Waiting for OST result</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Apr 17, 2018 at 1:25 PM, Tal Nisan <span dir="ltr"><<a href="mailto:tnisan@redhat.com" target="_blank">tnisan@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Looking at it, seems like WELD doesn't allow injections of from generic declared types, will most likely revert the original patch as I can't think of an elegant solution for the problem</div><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="h5">On Tue, Apr 17, 2018 at 11:31 AM, Gal Ben Haim <span dir="ltr"><<a href="mailto:gbenhaim@redhat.com" target="_blank">gbenhaim@redhat.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5"><div dir="ltr">Hi,<div><br></div><div>From last night, the Change Queue fails on every run because of "add_qos" test.</div><div><br></div><div>From the engine log:</div><div><br></div><div><pre style="color:rgb(0,0,0);word-wrap:break-word;white-space:pre-wrap">2018-04-16 10:31:51,813-04 ERROR [<a href="http://org.ovirt.engine.core.bll.Com">org.ovirt.engine.core.bll.Com</a><wbr>mandsFactory] (default task-30) [] An exception has occurred while trying to create a command object for command 'AddCpuQos' with parameters 'QosParametersBase:{commandId=<wbr>'ccb4d6f4-ca86-4706-921c-f8743<wbr>9e0550f', user='null', commandType='Unknown'}': WELD-001407: Cannot declare an injection point with a type variable: [BackedAnnotatedField] @Inject private org.ovirt.engine.core.bll.qos.<wbr>QosCommandBase.qosDao
at org.ovirt.engine.core.bll.qos.<wbr>QosCommandBase.qosDao(QosComma<wbr>ndBase.java:0)</pre><pre style="color:rgb(0,0,0);word-wrap:break-word;white-space:pre-wrap"><br></pre><pre style="word-wrap:break-word"><pre style="color:rgb(0,0,0);white-space:pre-wrap;word-wrap:break-word">2018-04-16 10:31:51,819-04 ERROR [<a href="http://org.ovirt.engine.core.bll.Com">org.ovirt.engine.core.bll.Com</a><wbr>mandsFactory] (default task-30) [] Exception: org.jboss.weld.exceptions.Defi<wbr>nitionException: WELD-001407: Cannot declare an injection point with a type variable: [BackedAnnotatedField] @Inject private org.ovirt.engine.core.bll.qos.<wbr>QosCommandBase.qosDao
at org.ovirt.engine.core.bll.qos.<wbr>QosCommandBase.qosDao(QosComma<wbr>ndBase.java:0)
StackTrace
at org.jboss.weld.bootstrap.Valid<wbr>ator.validateInjectionPointFor<wbr>DefinitionErrors(Validator.<wbr>java:295) [weld-core-impl-2.4.3.Final.ja<wbr>r:2.4.3.Final]
at org.jboss.weld.bootstrap.Valid<wbr>ator.validateInjectionPoint(Va<wbr>lidator.java:281) [weld-core-impl-2.4.3.Final.ja<wbr>r:2.4.3.Final]
at org.jboss.weld.bootstrap.Valid<wbr>ator.validateProducer(Validato<wbr>r.java:400) [weld-core-impl-2.4.3.Final.ja<wbr>r:2.4.3.Final]
at org.jboss.weld.injection.produ<wbr>cer.InjectionTargetService.val<wbr>idateProducer(InjectionTargetS<wbr>ervice.java:36) [weld-core-impl-2.4.3.Final.ja<wbr>r:2.4.3.Final]
at org.jboss.weld.manager.Injecti<wbr>onTargetFactoryImpl.validate(I<wbr>njectionTargetFactoryImpl.java<wbr>:135) [weld-core-impl-2.4.3.Final.ja<wbr>r:2.4.3.Final]
at org.jboss.weld.manager.Injecti<wbr>onTargetFactoryImpl.createInje<wbr>ctionTarget(InjectionTargetFac<wbr>toryImpl.java:79) [weld-core-impl-2.4.3.Final.ja<wbr>r:2.4.3.Final]
at org.jboss.weld.manager.Injecti<wbr>onTargetFactoryImpl.createInje<wbr>ctionTarget(InjectionTargetFac<wbr>toryImpl.java:69) [weld-core-impl-2.4.3.Final.ja<wbr>r:2.4.3.Final]
at org.jboss.weld.manager.BeanMan<wbr>agerImpl.createInjectionTarget<wbr>(BeanManagerImpl.java:1140) [weld-core-impl-2.4.3.Final.ja<wbr>r:2.4.3.Final]
at org.jboss.weld.util.Forwarding<wbr>BeanManager.createInjectionTar<wbr>get(ForwardingBeanManager.<wbr>java:201) [weld-core-impl-2.4.3.Final.ja<wbr>r:2.4.3.Final]
at org.ovirt.engine.core.di.Injec<wbr>tor.injectMembers(Injector.<wbr>java:29) [vdsbroker.jar:]
at org.ovirt.engine.core.bll.Comm<wbr>andsFactory.createCommand(Comm<wbr>andsFactory.java:100) [bll.jar:]
at org.ovirt.engine.core.bll.Back<wbr>end.runActionImpl(Backend.java<wbr>:433) [bll.jar:]
at org.ovirt.engine.core.bll.Back<wbr>end.runAction(Backend.java:<wbr>387) [bll.jar:]
at sun.reflect.NativeMethodAccess<wbr>orImpl.invoke0(Native Method) [rt.jar:1.8.0_161]</pre><pre style="color:rgb(0,0,0);white-space:pre-wrap;word-wrap:break-word"><br></pre><pre style="color:rgb(0,0,0);white-space:pre-wrap;word-wrap:break-word">Link to all logs:</pre><pre style="word-wrap:break-word"><font color="#000000"><span style="white-space:pre-wrap"><a href="http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/6839/artifact/exported-artifacts/basic-suit-master-el7/test_logs/basic-suite-master/" target="_blank">http://jenkins.ovirt.org/job/o<wbr>virt-master_change-queue-teste<wbr>r/6839/artifact/exported-artif<wbr>acts/basic-suit-master-el7/<wbr>test_logs/basic-suite-master/</a><span class="m_-5189009865590521474HOEnZb"><font color="#888888"><br></font></span></span></font></pre><span class="m_-5189009865590521474HOEnZb"><font color="#888888"><pre style="color:rgb(0,0,0);white-space:pre-wrap;word-wrap:break-word"><br></pre></font></span></pre></div><span class="m_-5189009865590521474HOEnZb"><font color="#888888"><div><div><br></div>-- <br><div class="m_-5189009865590521474m_-2464092753096780469gmail_signature"><div dir="ltr"><font face="overpass, sans-serif" color="#000000" size="2"><span style="text-transform:uppercase"><b>GAL bEN HAIM</b></span></font><div><span style="color:rgb(0,0,0);font-family:overpass,sans-serif;text-transform:uppercase"><font size="2">RHV DEVOPS</font></span><br></div></div></div>
</div></font></span></div>
<br></div></div>______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a><br></blockquote></div><br></div>
</blockquote></div><br></div>