<div dir="ltr">Hi Martin, <div> </div><div>I see [1] <span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">requires a rebase, can you please take care?</span></div><div><br></div><div>At the moment, our automation is stable only on iSCSI, NFS, Gluster and FC. </div><div>Ceph is not supported and Cinder will be stabilized soon, AFAIR, it's not stable enough at the moment.</div><div><br></div><div><br></div><div>[1] <span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"><a href="https://gerrit.ovirt.org/#/c/89830/">https://gerrit.ovirt.org/#/c/89830/</a><span> </span></span></div><div><br></div><div><br></div><div>Thanks</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Apr 18, 2018 at 2:17 PM, Martin Polednik <span dir="ltr"><<a href="mailto:mpolednik@redhat.com" target="_blank">mpolednik@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 18/04/18 11:37 +0300, Elad Ben Aharon wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi, sorry if I misunderstood, I waited for more input regarding what areas<br>
have to be tested here.<br>
</blockquote>
<br></span>
I'd say that you have quite a bit of freedom in this regard. GlusterFS<br>
should be covered by Dennis, so iSCSI/NFS/ceph/cinder with some suite<br>
that covers basic operations (start & stop VM, migrate it), snapshots<br>
and merging them, and whatever else would be important for storage<br>
sanity.<br>
<br>
mpolednik<div class="HOEnZb"><div class="h5"><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On Wed, Apr 18, 2018 at 11:16 AM, Martin Polednik <<a href="mailto:mpolednik@redhat.com" target="_blank">mpolednik@redhat.com</a>><br>
wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On 11/04/18 16:52 +0300, Elad Ben Aharon wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
We can test this on iSCSI, NFS and GlusterFS. As for ceph and cinder, will<br>
have to check, since usually, we don't execute our automation on them.<br>
<br>
</blockquote>
<br>
Any update on this? I believe the gluster tests were successful, OST<br>
passes fine and unit tests pass fine, that makes the storage backends<br>
test the last required piece.<br>
<br>
<br>
On Wed, Apr 11, 2018 at 4:38 PM, Raz Tamir <<a href="mailto:ratamir@redhat.com" target="_blank">ratamir@redhat.com</a>> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
+Elad<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
On Wed, Apr 11, 2018 at 4:28 PM, Dan Kenigsberg <<a href="mailto:danken@redhat.com" target="_blank">danken@redhat.com</a>><br>
wrote:<br>
<br>
On Wed, Apr 11, 2018 at 12:34 PM, Nir Soffer <<a href="mailto:nsoffer@redhat.com" target="_blank">nsoffer@redhat.com</a>> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
On Wed, Apr 11, 2018 at 12:31 PM Eyal Edri <<a href="mailto:eedri@redhat.com" target="_blank">eedri@redhat.com</a>> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Please make sure to run as much OST suites on this patch as possible<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
before merging ( using 'ci please build' )<br>
<br>
<br>
</blockquote>
But note that OST is not a way to verify the patch.<br>
<br>
Such changes require testing with all storage types we support.<br>
<br>
Nir<br>
<br>
On Tue, Apr 10, 2018 at 4:09 PM, Martin Polednik <<a href="mailto:mpolednik@redhat.com" target="_blank">mpolednik@redhat.com</a><br>
><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
wrote:<br>
<br>
Hey,<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
I've created a patch[0] that is finally able to activate libvirt's<br>
dynamic_ownership for VDSM while not negatively affecting<br>
functionality of our storage code.<br>
<br>
That of course comes with quite a bit of code removal, mostly in the<br>
area of host devices, hwrng and anything that touches devices; bunch<br>
of test changes and one XML generation caveat (storage is handled by<br>
VDSM, therefore disk relabelling needs to be disabled on the VDSM<br>
level).<br>
<br>
Because of the scope of the patch, I welcome storage/virt/network<br>
people to review the code and consider the implication this change<br>
has<br>
on current/future features.<br>
<br>
[0] <a href="https://gerrit.ovirt.org/#/c/89830/" rel="noreferrer" target="_blank">https://gerrit.ovirt.org/#/c/8<wbr>9830/</a><br>
<br>
<br>
</blockquote>
In particular: dynamic_ownership was set to 0 prehistorically (as<br>
</blockquote></blockquote>
part<br>
of <a href="https://bugzilla.redhat.com/show_bug.cgi?id=554961" rel="noreferrer" target="_blank">https://bugzilla.redhat.com/sh<wbr>ow_bug.cgi?id=554961</a> ) because<br>
libvirt,<br>
running as root, was not able to play properly with root-squash nfs<br>
mounts.<br>
<br>
Have you attempted this use case?<br>
<br>
I join to Nir's request to run this with storage QE.<br>
<br>
<br>
</blockquote>
<br>
<br>
--<br>
<br>
<br>
Raz Tamir<br>
Manager, RHV QE<br>
<br>
<br>
</blockquote></blockquote></blockquote></blockquote>
</div></div></blockquote></div><br></div>