<div dir="ltr">(adding devel because this might be interesting for others).<br><div><div class="gmail_extra"><br><div class="gmail_quote">On 1 May 2018 at 21:16, Greg Sheremeta <span dir="ltr"><<a href="mailto:gshereme@redhat.com" target="_blank">gshereme@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">How would I get this plugin added to ovirt-engine-dashboard and ovirt-engine-node* ?</div></blockquote><div><br></div><div>Its already available for all projects in <a href="http://gerrit.ovirt.org">gerrit.ovirt.org</a>.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div></div><div>And then how would I configure it? (Add myself as a default, at least)<br></div></div></blockquote><div><br></div><div>Two ways:<br><br></div><div>With the GUI:<br>-----------------<br><br></div><div>In Gerrit UI go to:<br><br></div><div>Admin -> Projects -> (Old UI) -> (Your project) -> Reviewers (from top bar)<br><br></div><div>Fill in filter (A file glob pattern - can be '*') and reviewer (An email address ora gerrit group ) and click "Add".<br><br></div><div>Don't forget to switch back to new UI from the bottom right link.<br></div><div> <br></div><div><br>From the command line<br></div><div>-------------------------------<br></div><div>In a Git clone of the relevant project do:<br><br># git fetch origin refs/meta/config:meta-config<br></div><div># git checkout meta-config<br><br></div><div>Then you can edit the 'reviewers.config' file (Make it if it isn't there) and put in something like the following:<br><br> [filter "*"]<br> reviewer = jenkins-maintainers<br> reviewer = <a href="mailto:dron@redhat.com">dron@redhat.com</a><br><br></div><div>Once you're done with it commit the change and push it with:<br><br></div><div># git push -u origin meta-config refs/meta/config<br></div><div><br></div><div>Since we have '-u' there, the next time around you change the 'meta-config' branch you can just do:<br><br># git push -u origin</div><div><br></div><div>And that's about it.<br><br></div><div>One thing to note - every project has a '<project-name>-maintainers' group, so its useful to add it it default.<br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div><br><div class="gmail_quote">---------- Forwarded message ----------<br>From: <b class="gmail_sendername">Roy Golan</b> <span dir="ltr"><<a href="mailto:rgolan@redhat.com" target="_blank">rgolan@redhat.com</a>></span><br>Date: Mon, Jun 19, 2017 at 7:17 AM<br>Subject: Re: [ovirt-devel] [ENGINE][ACTION_NEEDED] - default maintainers, per path<br>To: devel <<a href="mailto:devel@ovirt.org" target="_blank">devel@ovirt.org</a>><br><br><br><div dir="ltr"><div>The patch is now merged and the it should start working immediately. For anyone who is listed as a default reviewer I suggest to test it with a test patch by some other submitter. (except for those who used groups of course)<br><br></div>Thanks everyone for the cooperation on this.<br><br></div><div class="gmail-m_406953817666206022HOEnZb"><div class="gmail-m_406953817666206022h5"><br><div class="gmail_quote"><div dir="ltr">On Mon, May 29, 2017 at 2:24 PM Roy Golan <<a href="mailto:rgolan@redhat.com" target="_blank">rgolan@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div><div><div><div><div><div>Hi all, <br><br></div>Some time ago the infra team enabled <b>gerrit default reviewer plugin</b> which you probably noticed if you logged in to gerrit.<br><br></div>What we can do is for example set the stable branch maintainers per branch automatically:<br><br></div> <span style="font-family:monospace">[filter "branch:ovirt-engine-4.1"]<br></span></div><span style="font-family:monospace"> reviewer = stableBranchMaintainersGroup<br></span><br></div>Put people based on path:<br><br></div> <span style="font-family:monospace"> [filter "branch:master file:^frontend/.*"]<br></span></div><span style="font-family:monospace"> reviewer = <a href="mailto:j.r.r.t@shire.me" target="_blank">j.r.r.t@shire.me</a></span><br><div><div><div><div><div><div><div><br></div><div><br><b>Action Needed:<br></b></div><div>Nominate yourself, or others, by amending this patch online [1]. Once this patch is fully acked and agreed we will merge it. If something can't get consensus we will defer it from the patch till maintainers agree.<br><br>[1] <a href="https://gerrit.ovirt.org/#/c/77488/" target="_blank">https://gerrit.ovirt.org/#/c/7<wbr>7488/</a> <br></div><div><br><br><br></div><div> <br></div></div></div></div></div></div></div></div></blockquote></div>
</div></div><br>______________________________<wbr>_________________<br>
Devel mailing list<br>
<a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a><span class="gmail-HOEnZb"><font color="#888888"><br></font></span></div><span class="gmail-HOEnZb"><font color="#888888"><br><br clear="all"><div><br></div>-- <br><div class="gmail-m_406953817666206022gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase"><span>GREG</span> <span>SHEREMETA</span></p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase"><span>SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX</span><span style="color:rgb(170,170,170);margin:0px"></span></p><p style="font-family:overpass,sans-serif;margin:0px;font-size:10px;color:rgb(153,153,153)"><a href="https://www.redhat.com/" style="color:rgb(0,136,206);margin:0px" target="_blank">Red Hat NA<span><br><br></span></a></p><p style="font-family:overpass,sans-serif;margin:0px 0px 6px;font-size:10px;color:rgb(153,153,153)"><span style="margin:0px;padding:0px"><a href="mailto:gshereme@redhat.com" style="color:rgb(0,136,206);margin:0px" target="_blank">gshereme@redhat.com</a> </span> <span>IRC: <span>gshereme</span></span></p><table style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium" border="0"><tbody><tr><td width="100px"><a href="https://red.ht/sig" target="_blank"><img src="https://www.redhat.com/files/brand/email/sig-redhat.png" width="90" height="auto"></a></td></tr></tbody></table></div></div></div></div></div></div></div></div></div>
</font></span></div></div></div>
<br>______________________________<wbr>_________________<br>
Infra mailing list<br>
<a href="mailto:Infra@ovirt.org">Infra@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/infra" rel="noreferrer" target="_blank">http://lists.ovirt.org/<wbr>mailman/listinfo/infra</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature">Barak Korren<br>RHV DevOps team , RHCE, RHCi<br>Red Hat EMEA<br><a href="http://redhat.com" target="_blank">redhat.com</a> | TRIED. TESTED. TRUSTED. | <a href="http://redhat.com/trusted" target="_blank">redhat.com/trusted</a></div>
</div></div></div>