Change in ovirt-engine[master]: webadmin: Main events tab takes too long to fetch data

gchaplik at redhat.com gchaplik at redhat.com
Sun Aug 5 08:22:41 UTC 2012


Gilad Chaplik has submitted this change and it was merged.

Change subject: webadmin: Main events tab takes too long to fetch data
......................................................................


webadmin: Main events tab takes too long to fetch data

The same issue as already fixed for subtabs in:
eda0ef6be8ba97e6a835907a998683cdca1fcb74
The problem for main tab is that the main tab does not have the
entity set, so the refresh command was not executed.

Fixed by calling the refresh without the check on the
entity in the EventListModel and creating a new class
SubTabEventListModel which is a common parent for all
sub tab events and adding this check only here, so it will
apply only for the sub tabs.

Change-Id: I7d0d0df896113c2989a1864f2ca89d488a63e446
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterEventListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/EventListModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/SubTabEventListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeEventListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostEventListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaEventListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageEventListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateEventListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserEventListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmEventListModel.java
10 files changed, 33 insertions(+), 27 deletions(-)

Approvals:
  Gilad Chaplik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/6850
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7d0d0df896113c2989a1864f2ca89d488a63e446
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>



More information about the Engine-commits mailing list