Change in ovirt-engine[master]: engine: Fix NPE in SetupNetworksHelper (#842324)

mkolesni at redhat.com mkolesni at redhat.com
Sun Aug 5 12:27:09 UTC 2012


Mike Kolesnik has submitted this change and it was merged.

Change subject: engine: Fix NPE in SetupNetworksHelper (#842324)
......................................................................


engine: Fix NPE in SetupNetworksHelper (#842324)

https://bugzilla.redhat.com/842324

The method had relied on the new interface sent to determine if it's a
bond or a VLAN device, but it should instead check it on the existing
interface, thus avoiding relying on parameters that are sent by user.

Change-Id: I8d9a6f31a3c04068fac9bbcf2a06dc08d4b9794b
Signed-off-by: Mike Kolesnik <mkolesni at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Mike Kolesnik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/6895
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8d9a6f31a3c04068fac9bbcf2a06dc08d4b9794b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>



More information about the Engine-commits mailing list