Change in ovirt-engine[master]: tools: Add tolerance to engine-setup min memory threshold

oschreib at redhat.com oschreib at redhat.com
Wed Aug 8 10:22:54 UTC 2012


Ofer Schreiber has submitted this change and it was merged.

Change subject: tools: Add tolerance to engine-setup min memory threshold
......................................................................


tools: Add tolerance to engine-setup min memory threshold

engine-setup exits with error if system is under memory
threshold in basedefs.py (CONST_MIN_MEMORY_GB).
Since engine-setup is using 'free -g' command, using
default threshold (2GB), systems with less than 2048 MB
of RAM will be classified as 1 GB.
e.g. a system with 2048 MB with some memory allowed
to video cards will not be able to run engine setup.
This patch will change engine-setup to use 'free -m',
change the memory threshold to be in MB and add a
tolerance of 5% to MIN_MEMORY.

http://bugzilla.redhat.com/843621

Change-Id: Ibd22cccc85c62535c57b651347bd6e7ccedec625
Signed-off-by: Amador Pahim <apahim at redhat.com>
---
M packaging/fedora/setup/basedefs.py
M packaging/fedora/setup/engine-setup.py
M packaging/fedora/setup/output_messages.py
3 files changed, 12 insertions(+), 11 deletions(-)

Approvals:
  Ofer Schreiber: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/6992
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd22cccc85c62535c57b651347bd6e7ccedec625
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi at redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib at redhat.com>
Gerrit-Reviewer: Ohad Basan <obasan at redhat.com>



More information about the Engine-commits mailing list