Change in ovirt-engine[master]: core: fix AddDisk permission check

oourfali at redhat.com oourfali at redhat.com
Tue Aug 14 05:13:59 UTC 2012


Oved Ourfali has submitted this change and it was merged.

Change subject: core: fix AddDisk permission check
......................................................................


core: fix AddDisk permission check

When someone adds a floating from the webadmin UI, the vm id is
EMPTY_GUID. However, in the permissions check, we check for null.
This patch checks for null, and if the vm id isn't null, it checks if it
is an empty guid.

Change-Id: Ibf0220700a9675d17f553df2b96f2e1da3b621b1
Signed-off-by: Oved Ourfali <oourfali at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Oved Ourfali: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/7140
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf0220700a9675d17f553df2b96f2e1da3b621b1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmishra at linux.vnet.ibm.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list