Change in ovirt-engine[master]: webadmin: adding port mirroring indication to network interf...

alkaplan at redhat.com alkaplan at redhat.com
Sun Aug 19 08:45:26 UTC 2012


Alona Kaplan has submitted this change and it was merged.

Change subject: webadmin: adding port mirroring indication to network interface (#845991)
......................................................................


webadmin: adding port mirroring indication to network interface (#845991)

https://bugzilla.redhat.com/845991

Problem:
	there is no way to see if a nic has port mirroring enabled

Solution:
	added a column to the network interface tab indicating the use of port mirroring
	the indication is "Enabled" for true and blank for false

	created new column type BooleanColumn, shows a message by a boolean value
	added the needed column in SubTabVirtualMachineNetworkInterfaceView

Change-Id: I9949aea5b6817a898a51ffd496969d7217e5db20
Signed-off-by: Noam Slomianko <nslomian at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/BooleanColumn.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/BaseInterfaceListModelTable.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/virtualMachine/SubTabVirtualMachineNetworkInterfaceView.java
4 files changed, 39 insertions(+), 2 deletions(-)

Approvals:
  Alona Kaplan: Looks good to me, approved
  Noam Slomianko: Verified


--
To view, visit http://gerrit.ovirt.org/7124
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9949aea5b6817a898a51ffd496969d7217e5db20
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <nslomian at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Noam Slomianko <nslomian at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list