Change in ovirt-engine[master]: engine: Permission given to a group doesn't apply to its mem...

yzaslavs at redhat.com yzaslavs at redhat.com
Sun Aug 19 15:33:28 UTC 2012


Yair Zaslavsky has submitted this change and it was merged.

Change subject: engine: Permission given to a group doesn't apply to its member (#847333)
......................................................................


engine: Permission given to a group doesn't apply to its member (#847333)

This patch fixes creation of user_permission_permissions_view.
The error was that user of a group doesn't get the same permissions that the group does have.
The user gets its own specific permissions only.

This happens because the view user_permissions_permissions_view uses user_flat_groups in a wrong way,
the view is supposed to make a table of permissions connected to user_id as permission_view, but this view
connects also subusers of groups to their group's permissions.

It uses ad_element_id instead of use_id field, that's the reason why GetPermissionsByAdElementIdQuery
returns only permissions on specific user without including its group permissions.

Change-Id: Ice68f05528f5952848f47c029f2216d7ddd7899e
Signed-off-by: Yaniv Bronhaim  <ybronhei at redhat.com>
---
M backend/manager/dbscripts/create_views.sql
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Yair Zaslavsky: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/7262
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ice68f05528f5952848f47c029f2216d7ddd7899e
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list