Change in ovirt-engine[master]: core: Option with empty name and value ...

emesika at redhat.com emesika at redhat.com
Mon Aug 20 07:09:27 UTC 2012


Eli Mesika has submitted this change and it was merged.

Change subject: core: Option with empty name and value ...
......................................................................


core: Option with empty name and value ...

Option with empty name and value in the request's xml to rest-api should
not be allowed.

The problem is not with the PM options, this is working without a
problem.
There is a leading blank in the UUID of the DC in the request that
caused the exception.
Adding a check for DC ID validity in canDoAction of
ConnectStorageToVdsCommand command.

Change-Id: Ife629f861c1dfa9e0ab57392b77a09d79fe65d47
Signed-off-by: Eli Mesika <emesika at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectStorageToVdsCommand.java
1 file changed, 9 insertions(+), 0 deletions(-)

Approvals:
  Eli Mesika: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/7321
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ife629f861c1dfa9e0ab57392b77a09d79fe65d47
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list