Change in ovirt-engine[master]: core: Fix potential NPE when adding LUN disk (#850795)

mlipchuk at redhat.com mlipchuk at redhat.com
Thu Aug 23 14:40:57 UTC 2012


Maor Lipchuk has submitted this change and it was merged.

Change subject: core: Fix potential NPE when adding LUN disk (#850795)
......................................................................


core: Fix potential NPE when adding LUN disk (#850795)

https://bugzilla.redhat.com/show_bug.cgi?id=850795

Since LUN disk is not part of a storage pool, validation for shareable disk
should be only on image disk.

The proposed fix, move the validation of supported DC version to image disk.

Change-Id: I6c55b95dac6f70435f7d1ac02a6a2a7cdd3f1e91
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
1 file changed, 6 insertions(+), 7 deletions(-)

Approvals:
  Maor Lipchuk: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/7362
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6c55b95dac6f70435f7d1ac02a6a2a7cdd3f1e91
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list