Change in ovirt-engine[master]: core: NPE in remove from export domain (#847652)

gchaplik at redhat.com gchaplik at redhat.com
Tue Aug 28 09:38:53 UTC 2012


Gilad Chaplik has submitted this change and it was merged.

Change subject: core: NPE in remove from export domain (#847652)
......................................................................


core: NPE in remove from export domain (#847652)

https://bugzilla.redhat.com/847652

While removing VM/Template from export domain, in endCommand we construct the
command again and try to fetch the vm/template, which will fail (because
the vm/template doesn't exist), therefore, we need a Null check there.

Change-Id: I8b65227d94ba426b943181398fcd06b6137638fa
Signed-off-by: Gilad Chaplik <gchaplik at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java
2 files changed, 16 insertions(+), 4 deletions(-)

Approvals:
  Gilad Chaplik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/7523
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8b65227d94ba426b943181398fcd06b6137638fa
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list