Change in ovirt-engine[master]: webadmin: Check HTTP response status for Reports.xml

vszocs at redhat.com vszocs at redhat.com
Tue Aug 28 11:28:19 UTC 2012


Vojtech Szocs has submitted this change and it was merged.

Change subject: webadmin: Check HTTP response status for Reports.xml
......................................................................


webadmin: Check HTTP response status for Reports.xml

In ReportInit.parseReportsXML method, HTTP response status
should be checked first, before trying to parse response
text as XML.

For example, missing Reports.xml will cause 404 (not found)
HTTP response, with response text being HTML (error page).

Change-Id: I40823031291c6223cf9acb484e5b20d74baa8142
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ReportInit.java
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Vojtech Szocs: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/7512
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I40823031291c6223cf9acb484e5b20d74baa8142
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list