Change in ovirt-engine[master]: webadmin: DataProvider.java cleanup (5/6)

gchaplik at redhat.com gchaplik at redhat.com
Sun Dec 16 13:41:36 UTC 2012


Gilad Chaplik has submitted this change and it was merged.

Change subject: webadmin: DataProvider.java cleanup (5/6)
......................................................................


webadmin: DataProvider.java cleanup (5/6)

DataProvider is a class which is mostly obsolete,
as it contains synchronous calls to the engine,
which are not relevant anymore under the GWT platform/infrastructure.

The goal is to eliminate this class all-together.

In this patch:
Removing sync call for IsVmNameUnique, and replacing it with
an async call in AsyncDataProvider

Change-Id: If11911f94e02a5c115a4c4407b918580704bd9eb
Signed-off-by: Gilad Chaplik <gchaplik at redhat.com>
Bug-Url: https://bugzilla.redhat.com/881747
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
2 files changed, 32 insertions(+), 30 deletions(-)

Approvals:
  Gilad Chaplik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/9721
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If11911f94e02a5c115a4c4407b918580704bd9eb
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>



More information about the Engine-commits mailing list