Change in ovirt-engine[master]: core: Fix IndexOutOfBoundsException in plug FC disk

mlipchuk at redhat.com mlipchuk at redhat.com
Mon Dec 17 12:12:13 UTC 2012


Maor Lipchuk has submitted this change and it was merged.

Change subject: core: Fix IndexOutOfBoundsException in plug FC disk
......................................................................


core: Fix IndexOutOfBoundsException in plug FC disk

Attach/Detach and plug disk throws an indexOutOfBoundsException.
The reason for that is that the FC LUN which the disk is related to does not contains any
connections in it, as opposed to ISCSI lun which must have connections
related to it.

The proposed fix is to use FCP storage type if the LUN does not contain
any connections in it.

Change-Id: I6414445b9a74be299205ff7fc9a21d1388a29687
Bug-Url: https://bugzilla.redhat.com/882825
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommandTest.java
2 files changed, 61 insertions(+), 4 deletions(-)

Approvals:
  Maor Lipchuk: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/9724
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6414445b9a74be299205ff7fc9a21d1388a29687
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmishra at linux.vnet.ibm.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: liron aravot <liron.aravot at gmail.com>



More information about the Engine-commits mailing list