Change in ovirt-engine[master]: core: error when adding disks without specifying storage dom...

mlipchuk at redhat.com mlipchuk at redhat.com
Mon Dec 24 12:29:19 UTC 2012


Maor Lipchuk has submitted this change and it was merged.

Change subject: core: error when adding disks without specifying storage domain
......................................................................


core: error when adding disks without specifying storage domain

When adding a disk and no storage domain id is passed by the parameters,
there is an attempt to get the storage domain id from the first vm disk
- if this disk is a LUN disk, it won't have storage domain id and we won't
be able to add the new image disk.

Change-Id: Icc3fce53eaeca31b7b479019ba195b60e248c88e
Bug-Url: https://bugzilla.redhat.com/876109
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
1 file changed, 22 insertions(+), 9 deletions(-)

Approvals:
  Maor Lipchuk: Looks good to me, approved
  Liron Aravot: Verified; Looks good to me, but someone else must approve


--
To view, visit http://gerrit.ovirt.org/10289
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icc3fce53eaeca31b7b479019ba195b60e248c88e
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>



More information about the Engine-commits mailing list