Change in ovirt-engine[master]: engine: Refactor NetworkCommon

mkolesni at redhat.com mkolesni at redhat.com
Sun Dec 30 06:36:16 UTC 2012


Mike Kolesnik has submitted this change and it was merged.

Change subject: engine: Refactor NetworkCommon
......................................................................


engine: Refactor NetworkCommon

1. Change inheritance to CommandBase since this is not a storage
command, and seems that all it got from the storage command was
permissions (which are explicit here anyways).
2. Change to abstract - no need for empty implementation of
executeCommand.
3. Ignored serialization ID warning since this class not serialized
anyway.

Change-Id: I17590518c681f72c638188275ec75a651a9cf5ff
Signed-off-by: Mike Kolesnik <mkolesni at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/NetworkCommon.java
1 file changed, 3 insertions(+), 8 deletions(-)

Approvals:
  Mike Kolesnik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/10454
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I17590518c681f72c638188275ec75a651a9cf5ff
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Muli Salem <msalem at redhat.com>



More information about the Engine-commits mailing list