Change in ovirt-engine[master]: engine: Port mirroring setting requires a network

alkaplan at redhat.com alkaplan at redhat.com
Sun Dec 30 14:23:03 UTC 2012


Alona Kaplan has submitted this change and it was merged.

Change subject: engine: Port mirroring setting requires a network
......................................................................


engine: Port mirroring setting requires a network

A canDoAction should be thrown if on the vnic there is no network but the
port mirroring is enabled.

updated commands-
- AddVmInterfaceCommand
- UpdateVmInterface

Change-Id: Iece0f6de799f1eb0e3022bb69167b1553ab2f790
Signed-off-by: Alona Kaplan <alkaplan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmNicValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VmNicValidatorTest.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
9 files changed, 47 insertions(+), 2 deletions(-)

Approvals:
  Alona Kaplan: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/10442
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iece0f6de799f1eb0e3022bb69167b1553ab2f790
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>



More information about the Engine-commits mailing list