Change in ovirt-engine[master]: packaging: Improvements for the engine start/stop script

oschreib at redhat.com oschreib at redhat.com
Tue Jul 3 10:14:50 UTC 2012


Ofer Schreiber has submitted this change and it was merged.

Change subject: packaging: Improvements for the engine start/stop script
......................................................................


packaging: Improvements for the engine start/stop script

Some improvements for the engine start/stop script:

1. Read directly the /etc/sysconfig/ovirt-engine file, so the
engine-service.sh file is no longed needed in environments that
use SystemV scripts.

2. Check the ownership of log files.

3. Check the ownership of the locks directory.

4. Use the standard SystemV start/stop messages and colors.

5. Move the engine-service-logging.properties and from
/etc/ovirt-engine to /usr/share/ovirt-engine and have it owned by
root instead by ovirt, as the engine doesn't need to write to it.

6. Remove the engine-service-users.properties and the
corresponding configuration from the engine-service.xml file.

7. Set resource limits.

8. Add the ENGINE_PROPERTIES variable that can be used to provide
extra system properties to java virtual machine of the engine.

9. Add the restart option and friendly status messages.

Change-Id: I1bada51416584b0f7df1c87484aa3cc8c51aeeb0
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M Makefile
D packaging/fedora/engine-service-users.properties
M packaging/fedora/engine-service.py
M packaging/fedora/engine-service.sysconfig
M packaging/fedora/engine-service.systemd
D packaging/fedora/engine-service.systemv
M packaging/fedora/engine-service.xml
M packaging/fedora/spec/ovirt-engine.spec.in
8 files changed, 281 insertions(+), 139 deletions(-)

Approvals:
  Juan Hernandez: Verified
  Ofer Schreiber: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/5355
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1bada51416584b0f7df1c87484aa3cc8c51aeeb0
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib at redhat.com>



More information about the Engine-commits mailing list