Change in ovirt-engine[master]: core: RegisterVdsQuery - BitSet instead of indexOf

tnisan at redhat.com tnisan at redhat.com
Wed Jul 18 15:06:47 UTC 2012


Tal Nisan has submitted this change and it was merged.

Change subject: core: RegisterVdsQuery - BitSet instead of indexOf
......................................................................


core: RegisterVdsQuery - BitSet instead of indexOf

instead of using String's indexOf function for checking if a
char is valid for VDS Id - use Bitset.

Change-Id: I87bfd86839080b47d898de1f11c6f8f404eb0fc8
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RegisterVdsQueryTest.java
2 files changed, 76 insertions(+), 8 deletions(-)

Approvals:
  Tal Nisan: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/5619
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I87bfd86839080b47d898de1f11c6f8f404eb0fc8
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list