Change in ovirt-engine[master]: core: RemoveImageCommand: Extract initializers

mlipchuk at redhat.com mlipchuk at redhat.com
Mon Jul 23 15:08:56 UTC 2012


Maor Lipchuk has submitted this change and it was merged.

Change subject: core: RemoveImageCommand: Extract initializers
......................................................................


core: RemoveImageCommand: Extract initializers

Moved initialization code that may access the database from the
constructor to init methods so they can be overloaded in unit tests.

Change-Id: I4c7a544f96b3ba157283becc071898ac9d0bee08
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java
2 files changed, 21 insertions(+), 7 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, but someone else must approve
  Maor Lipchuk: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/6409
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4c7a544f96b3ba157283becc071898ac9d0bee08
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>



More information about the Engine-commits mailing list