Change in ovirt-engine[master]: core: Preserve 404 error code in error page (#842653)

vszocs at redhat.com vszocs at redhat.com
Tue Jul 24 16:11:09 UTC 2012


Vojtech Szocs has submitted this change and it was merged.

Change subject: core: Preserve 404 error code in error page (#842653)
......................................................................


core: Preserve 404 error code in error page (#842653)

https://bugzilla.redhat.com/842653

We used to redirect to the error page in order to avoid problems
with relative URLs, but this is causing problems with clients (GWT
for example) that follow the redirect and this don't recieve the
error code. This patch replaces the redirect with forward and
fixes the error page (the index page in fact) so that it doesn't
use relative URLs.

Change-Id: I84001b195c06ae8be38e500ba687353080d04830
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
D backend/manager/modules/root/src/main/java/org/ovirt/engine/core/ErrorServlet.java
M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml
M backend/manager/modules/root/src/main/webapp/index.html
3 files changed, 6 insertions(+), 35 deletions(-)

Approvals:
  Vojtech Szocs: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/6573
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I84001b195c06ae8be38e500ba687353080d04830
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>



More information about the Engine-commits mailing list