Change in ovirt-engine[master]: core: UnPowerMock RemoveAdGroupCommandTest

[mkublin at redhat.com]

Michael Kublin has submitted this change and it was merged.

Change subject: core: UnPowerMock RemoveAdGroupCommandTest
......................................................................


core: UnPowerMock RemoveAdGroupCommandTest

Removed PowerMock dependency from RemoveAdGroupCommandTest, and replaced
it with spying the command's relevant method.

In order to achieve this improvement a small refactoring was required in
RemoveAdGroupCommand.
CanRemoveAdGroup was turned into a private instance method (instead of a
static public one), and isLastSuperUserGroup was extracted so the
MultiLevelAdministrationHandler dependecy could be mocked away.

Change-Id: Icf5d7eb0e15c92a43b88f7705754ca8238a48d97
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAdGroupCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveAdGroupCommandTest.java
2 files changed, 34 insertions(+), 94 deletions(-)

Approvals:
  Michael Kublin: Looks good to me, approved
  Allon Mureinik: Verified; Looks good to me, but someone else must approve


--
To view, visit http://gerrit.ovirt.org/4932
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icf5d7eb0e15c92a43b88f7705754ca8238a48d97
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>