Change in ovirt-engine[master]: core: UnPowerMock UpdateVdsGroupCommandTest

mkublin at redhat.com mkublin at redhat.com
Thu Jun 7 11:32:38 UTC 2012


Michael Kublin has submitted this change and it was merged.

Change subject: core: UnPowerMock UpdateVdsGroupCommandTest
......................................................................


core: UnPowerMock UpdateVdsGroupCommandTest

Removed PowerMock dependency from UpdateVdsGroupCommandTest and replaced
it with spying the command and using MockConfigRule.

In order to achieve this improvement, some refactoring was done to
UpdateVdsGroupCommand where some DAO access methods and
CpuFlagsManagerHandler methods were wrapped and extracted.

Change-Id: I94f8ea93cc9af7c93660d905cbb888f23b33c3c4
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommandTest.java
2 files changed, 126 insertions(+), 137 deletions(-)

Approvals:
  Michael Kublin: Looks good to me, approved
  Allon Mureinik: Verified; Looks good to me, but someone else must approve


--
To view, visit http://gerrit.ovirt.org/4938
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I94f8ea93cc9af7c93660d905cbb888f23b33c3c4
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list