Change in ovirt-engine[master]: core: OVF writer should not depend on LANG setting

oourfali at redhat.com oourfali at redhat.com
Tue Jun 12 14:35:16 UTC 2012


Oved Ourfali has submitted this change and it was merged.

Change subject: core: OVF writer should not depend on LANG setting
......................................................................


core: OVF writer should not depend on LANG setting

The XML writer used to write OVF doesn't specify the character
encoding when creating files. As a result the system selects the
encoding according to the setting of the LANG variable. This will
usually result in selecting UTF-8, but if it happens to be ASCII
the StAX writer will fail and complain that the header of the XML
document doesn't match the encoding of the string. This patch
changes the XML writer so that it always uses the UTF-8 encoding,
regardless of the LANG setting.

Change-Id: I2d3f1693cb0f1c2490360350936a4bff09549e72
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/XmlTextWriter.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Oved Ourfali: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/5289
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2d3f1693cb0f1c2490360350936a4bff09549e72
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>



More information about the Engine-commits mailing list