Change in ovirt-engine[master]: webadmin: LOCALFS storage path regex validation.

gchaplik at redhat.com gchaplik at redhat.com
Mon Jun 18 14:59:05 UTC 2012


Gilad Chaplik has submitted this change and it was merged.

Change subject: webadmin: LOCALFS storage path regex validation.
......................................................................


webadmin: LOCALFS storage path regex validation.

LOCALFS storage path is not validated with regex in frontend, being sent
to the backend/vdsm as is, even invalid. On the other hand, adding a NFS
storage, the path is validated in frontend, avoiding extra processing
and quickly/clearly informing user about what's wrong.
This patch adds the LOCALFS path validation in frontend, in order to
standardize according with the NFS regex path validation.

Change-Id: I89a768957974b67754f5a3b78ec8f773e25adc7b
Signed-off-by: Amador Pahim <apahim at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/LocalStorageModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/LocalfsLinuxMountPointValidation.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java
3 files changed, 39 insertions(+), 1 deletion(-)

Approvals:
  Gilad Chaplik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/4857
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I89a768957974b67754f5a3b78ec8f773e25adc7b
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>



More information about the Engine-commits mailing list