Change in ovirt-engine[master]: engine: Reduce flood of polling attempts/logs

mkolesni at redhat.com mkolesni at redhat.com
Tue Jun 19 06:16:00 UTC 2012


Mike Kolesnik has submitted this change and it was merged.

Change subject: engine: Reduce flood of polling attempts/logs
......................................................................


engine: Reduce flood of polling attempts/logs

When SetupNetworksCommand was run and the host didn't lose connectivity
with the engine, we would poll it relentlessly.
This would cause a log flood on both the host and the engine, and also
generates needless traffic over the network.

Added a 0.5 second cooldown period betweeb polling attempts, unless the
polling took more than that time (which probably was caused due to lost
connectivity).
Also reduced the verbosity of the logs on the engine side.

Change-Id: I324e326a6ea8ef92195dd22218bc619a49fe574a
Signed-off-by: Mike Kolesnik <mkolesni at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/PollVDSCommand.java
2 files changed, 10 insertions(+), 1 deletion(-)

Approvals:
  Mike Kolesnik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/5357
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I324e326a6ea8ef92195dd22218bc619a49fe574a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmishra at linux.vnet.ibm.com>



More information about the Engine-commits mailing list