Change in ovirt-engine[master]: core: add permission for changing custom properties

ofrenkel at redhat.com ofrenkel at redhat.com
Sun Jun 24 15:32:47 UTC 2012


Omer Frenkel has submitted this change and it was merged.

Change subject: core: add permission for changing custom properties
......................................................................


core: add permission for changing custom properties

in order to change custom properties user need to have explicit permission
permission check added to addVm, updateVm, importVm, runVm
permission added to admin roles that have all vm actions allowed:
super user, dc admin, cluster admin

Change-Id: If7409927233901439e33ec31c1091dd5948953e7
Signed-off-by: Omer Frenkel <ofrenkel at redhat.com>
---
A backend/manager/dbscripts/upgrade/03_01_1250_add_custom_props_action_group.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/PermitType.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermitMapper.java
10 files changed, 94 insertions(+), 2 deletions(-)

Approvals:
  Omer Frenkel: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/5492
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If7409927233901439e33ec31c1091dd5948953e7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Ori Liel <oliel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list