Change in ovirt-engine[master]: core: On scale environment restart jbossas service causes in...

[mkublin at redhat.com]

Michael Kublin has submitted this change and it was merged.

Change subject: core: On scale environment restart jbossas service causes initialization of Engine.ear to fail on timeout
......................................................................


core: On scale environment restart jbossas service causes initialization of Engine.ear to fail on timeout

The following problem occurred during restart of jboss, the most long process which take around 50 seconds was
init of MacPoolManger, the reason is a number of vms which were defined at system.
A process of init is retrieves all vms from db and after that tries to retrieve all theirs network interfaces, that
process can take a while.
Proposed solution:
1. Remove unneeded inits from InitBackendServicesOnStartupBean
2. Start init of MacPoolManager at separate thread
3. Optimization of MacPoolManger : start using HashSet instead of List, paying memory, reducing a time
4. Fixing bug with possible ConcurrentModificationException
5. Small clean up

Change-Id: If3bab39681d92a455aef8d642dcb74dde144b396
Signed-off-by: Michael Kublin <mkublin at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MacPoolManager.java
2 files changed, 26 insertions(+), 19 deletions(-)

Approvals:
  Michael Kublin: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/5665
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If3bab39681d92a455aef8d642dcb74dde144b396
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>