Change in ovirt-engine[master]: webadmin: Use an absolute URL for spice CABs

vszocs at redhat.com vszocs at redhat.com
Fri Jun 29 12:18:32 UTC 2012


Vojtech Szocs has submitted this change and it was merged.

Change subject: webadmin: Use an absolute URL for spice CABs
......................................................................


webadmin: Use an absolute URL for spice CABs

We are currently using URLs relative to the webadmin and user
portal applications in order to locate the spice .cab files. This
forces the spice package to be installed or symlinked inside the
user portal application, which is not nice.

This change uses an URL relative to the root of the server and
configures the file servlet to get the .cab files from their
original location in the file system. It currently assumes that
.cab files are located in /usr/share/spice, but this can be
quickly changed in the web.xml file of the root.war application.

Change-Id: Id22b30f8120e281187572b164b88fa9c260f61dd
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceInterfaceImpl.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java
4 files changed, 96 insertions(+), 14 deletions(-)

Approvals:
  Vojtech Szocs: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/5612
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id22b30f8120e281187572b164b88fa9c260f61dd
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>



More information about the Engine-commits mailing list