Change in ovirt-engine[master]: core: Clear NPEs from unit-tests

masayag at redhat.com masayag at redhat.com
Thu May 10 13:09:53 UTC 2012


Moti Asayag has submitted this change and it was merged.

Change subject: core: Clear  NPEs from unit-tests
......................................................................


core: Clear  NPEs from unit-tests

The patch replaces a direct call in AuditLogableBase to
DbFacade.getInstance() called on members initialization so mocking
DbFacage will not be required for each command class creation.

Change-Id: I42b9391c350ebfb943052038d90d997373dd141d
Signed-off-by: Moti Asayag <masayag at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java
2 files changed, 22 insertions(+), 17 deletions(-)

Approvals:
  Moti Asayag: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/4276
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I42b9391c350ebfb943052038d90d997373dd141d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list